From: Jakub Narebski <jnareb@gmail.com>
To: git@vger.kernel.org
Cc: John 'Warthog9' Hawley <warthog9@kernel.org>
Subject: Re: [PATCH 1/7] gitweb: Load checking
Date: Wed, 13 Jan 2010 18:18:37 +0100 [thread overview]
Message-ID: <201001131818.38703.jnareb@gmail.com> (raw)
In-Reply-To: <1263374828-15342-2-git-send-email-warthog9@eaglescrag.net>
On Wed, 13 Jan 2010, John 'Warthog9' Hawley wrote:
>
> v3 - warthog9: small additional adjustment to indicate where new load
> checking should be added for future improvements
> v2 - Jakub: switching to using
"switching to using" what?
> v1 - warthog9: Initial creation
>
> Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
Also, such comments should be put in the comment section, here i.e. between
"---\n" separator and the diffstat, and not in the commit message.
> gitweb/README | 7 ++++++-
> gitweb/gitweb.perl | 45 +++++++++++++++++++++++++++++++++++++++++----
> 2 files changed, 47 insertions(+), 5 deletions(-)
Other that this minor nick (which I guess could be fixed by Junio when
applying), this one looks good.
--
Jakub Narebski
Poland
next parent reply other threads:[~2010-01-13 17:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1263374828-15342-1-git-send-email-warthog9@eaglescrag.net>
[not found] ` <1263374828-15342-2-git-send-email-warthog9@eaglescrag.net>
2010-01-13 17:18 ` Jakub Narebski [this message]
[not found] ` <1263374828-15342-3-git-send-email-warthog9@eaglescrag.net>
2010-01-13 17:33 ` [PATCH 2/7] gitweb: Add option to force version match Jakub Narebski
2010-01-13 9:34 [PATCH 0/7] Gitweb caching v4 John 'Warthog9' Hawley
2010-01-13 9:34 ` [PATCH 1/7] gitweb: Load checking John 'Warthog9' Hawley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001131818.38703.jnareb@gmail.com \
--to=jnareb@gmail.com \
--cc=git@vger.kernel.org \
--cc=warthog9@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.