From: Al Viro <viro@ZenIV.linux.org.uk>
To: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Cc: Tyler Hicks <tyhicks@linux.vnet.ibm.com>,
Dustin Kirkland <kirkland@canonical.com>,
ecryptfs-devel@lists.launchpad.net, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ecryptfs: Fix refcnt leak on ecryptfs_follow_link() error path
Date: Wed, 13 Jan 2010 19:44:58 +0000 [thread overview]
Message-ID: <20100113194458.GB4673@ZenIV.linux.org.uk> (raw)
In-Reply-To: <87my0kjxpd.fsf@devron.myhome.or.jp>
On Tue, Jan 12, 2010 at 03:36:14AM +0900, OGAWA Hirofumi wrote:
>
> If ->follow_link handler return the error, it should decrement
> nd->path refcnt. But, ecryptfs_follow_link() doesn't decrement.
>
> This patch fix it by using usual nd_set_link() style error handling,
> instead of playing with nd->path.
Applied.
next prev parent reply other threads:[~2010-01-13 19:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 18:36 [PATCH] ecryptfs: Fix refcnt leak on ecryptfs_follow_link() error path OGAWA Hirofumi
2010-01-13 19:44 ` Al Viro [this message]
2010-01-14 3:32 ` OGAWA Hirofumi
2010-01-14 3:43 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100113194458.GB4673@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=ecryptfs-devel@lists.launchpad.net \
--cc=hirofumi@mail.parknet.co.jp \
--cc=kirkland@canonical.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tyhicks@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.