All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@redhat.com>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfsprogs: fix build with latest glibc headers
Date: Wed, 13 Jan 2010 16:42:06 -0500	[thread overview]
Message-ID: <20100113214206.GA23091@infradead.org> (raw)
In-Reply-To: <4B4E365E.8000306@redhat.com>

On Wed, Jan 13, 2010 at 03:08:46PM -0600, Eric Sandeen wrote:
> glibc in rawhide has some changes...
> 
> * Tue Jan 12 2010 Andreas Schwab <schwab@redhat.com> - 2.11.90-8
> - Update from master.
>   - More POSIX conformance fixes.
> 
> * Mon Jan 11 2010 Andreas Schwab <schwab@redhat.com> - 2.11.90-6
> - Update from master.
>   - POSIX conformance fixes (BZ#11125).

Great, eh? :)

> @@ -102,7 +102,7 @@ GCCFLAGS = -funsigned-char -fno-strict-aliasing -Wall
>  #	   -Wbitwise -Wno-transparent-union -Wno-old-initializer -Wno-decl
>  
>  ifeq ($(PKG_PLATFORM),linux)
> -PCFLAGS = -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 $(GCCFLAGS)
> +PCFLAGS = -D_GNU_SOURCE -D_XOPEN_SOURCE=500 -D_FILE_OFFSET_BITS=64 $(GCCFLAGS)

We might aswell got to -D_XOPEN_SOURCE=700 which is the newest revision and
should give us just about everything we might need.


But generally this looks okay to me,


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-01-13 21:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13 21:08 [PATCH] xfsprogs: fix build with latest glibc headers Eric Sandeen
2010-01-13 21:42 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100113214206.GA23091@infradead.org \
    --to=hch@infradead.org \
    --cc=sandeen@redhat.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.