From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Ben Dooks <ben-linux@fluff.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 2.6.33] s3c-fb: Fix handling of missing refresh in platform data
Date: Thu, 14 Jan 2010 10:20:27 +0000 [thread overview]
Message-ID: <20100114102027.GC437@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20100114073617.GT3738@trinity.fluff.org>
On Thu, Jan 14, 2010 at 07:36:17AM +0000, Ben Dooks wrote:
> Thirdly he's changed the code to calculate the divider to assume pixclk
> is a frequency, and not a time-period. It clearly stats in the docs
> that pixclk is in picoseconds. Our clock rate is in Hz.
> It seems I wasn't cc'd on the original submission or I'd have said no.
> I'd rather see this one reverted.
A revert also does the job for SMDK6410 (and does it better) so that
sounds good to me too - I'd been wondering why I couldn't figure out
what was supposed to go in there. I'll send something out with a
changelog shortly.
next prev parent reply other threads:[~2010-01-14 10:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 16:16 [PATCH 2.6.33] s3c-fb: Fix handling of missing refresh in platform data Mark Brown
2010-01-14 7:36 ` Ben Dooks
2010-01-14 10:20 ` Mark Brown [this message]
2010-01-14 10:26 ` [PATCH 2.6.33] s3c-fb: Fix divide by zero and broken output Mark Brown
2010-01-14 23:06 ` Andrew Morton
2010-01-15 0:01 ` Mark Brown
2010-01-15 0:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114102027.GC437@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=ben-linux@fluff.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.