From: Aurelien Jarno <aurelien@aurel32.net>
To: Vince Weaver <vince@csl.cornell.edu>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] alpha-linux-user stat64 issue
Date: Thu, 14 Jan 2010 16:00:57 +0100 [thread overview]
Message-ID: <20100114150057.GA16630@volta.aurel32.net> (raw)
In-Reply-To: <20091228235833.H44497@stanley.csl.cornell.edu>
On Tue, Dec 29, 2009 at 12:01:22AM -0500, Vince Weaver wrote:
> Hello
>
> The stat64/fstat64 syscalls are broken for alpha linux-user.
>
> This is because Alpha, even though it is native 64-bits, has a stat64
> syscall that is different than regular stat. This means that the
> "TARGET_LONG_BITS==64" check in syscall.c isn't enough. Below is
> a patch that fixes things for me, although it might not be the cleanest
> fix.
>
> This issue keeps sixtrack and fma3d spec2k benchmarks from running.
Thanks, applied.
> Vince
>
> Signed-off-by: Vince Weaver <vince@csl.cornell.edu>
>
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index 1acf1f5..f2dd39e 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -4004,7 +4004,7 @@ static inline abi_long host_to_target_stat64(void *cpu_env,
> } else
> #endif
> {
> -#if TARGET_LONG_BITS == 64
> +#if (TARGET_LONG_BITS == 64) && (!defined(TARGET_ALPHA))
> struct target_stat *target_st;
> #else
> struct target_stat64 *target_st;
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
prev parent reply other threads:[~2010-01-14 15:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091228235833.H44497@stanley.csl.cornell.edu>
2010-01-04 20:11 ` [Qemu-devel] [patch] alpha-linux-user stat64 issue Richard Henderson
2010-01-14 15:00 ` Aurelien Jarno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100114150057.GA16630@volta.aurel32.net \
--to=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
--cc=vince@csl.cornell.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.