From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: EDID accept separate sync video mode Date: Thu, 14 Jan 2010 21:04:15 +0200 Message-ID: <20100114190415.GE13045@sci.fi> References: <1263492140-6657-1-git-send-email-jglisse@redhat.com> <1263492140-6657-2-git-send-email-jglisse@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <1263492140-6657-2-git-send-email-jglisse@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.sourceforge.net To: Jerome Glisse Cc: dri-devel@lists.sf.net List-Id: dri-devel@lists.freedesktop.org On Thu, Jan 14, 2010 at 07:02:20PM +0100, Jerome Glisse wrote: > X is accepting such video mode, do the same. Pointed out by Joshua Roys > on IRC. Fix https://bugzilla.redhat.com/show_bug.cgi?id=3D540024 > = > Signed-off-by: Jerome Glisse > --- > drivers/gpu/drm/drm_edid.c | 1 - > 1 files changed, 0 insertions(+), 1 deletions(-) > = > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index 5c9f798..6d66383 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -634,7 +634,6 @@ static struct drm_display_mode *drm_mode_detailed(str= uct drm_device *dev, > } > if (!(pt->misc & DRM_EDID_PT_SEPARATE_SYNC)) { > printk(KERN_WARNING "integrated sync not supported\n"); > - return NULL; > } I suppose the patch title should be 'accept composite sync'. Perhaps the error message could say composite sync too since then people would know what it's trying to say. At least I've never heard the term integrated sync before. -- = Ville Syrj=E4l=E4 syrjala@sci.fi http://www.sci.fi/~syrjala/ ---------------------------------------------------------------------------= --- Throughout its 18-year history, RSA Conference consistently attracts the world's best and brightest in the field, creating opportunities for Confere= nce attendees to learn about information security's most important issues throu= gh interactions with peers, luminaries and emerging and established companies. http://p.sf.net/sfu/rsaconf-dev2dev --