[Qemu-devel] Error message regression

[Qemu-devel] Error message regression

[Aurelien Jarno]

Starting with commit 0e8c9214ba1d4128cf92442cd343bc3733478261, when
trying to run make without running configure first, the error message
has been changed from: 

| $ make
| Please call configure before running make!
| make: *** [config-host.mak] Erreur 1

to this more cryptic message:

| $ make
| Makefile:78: /Makefile.objs: No such file or directory
| make: *** No rule to make target `/Makefile.objs'.  Stop.

Any idea how to fix that properly?

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

[Qemu-devel] [PATCH] Makefile: Fix message for missing configure

[Stefan Weil]

When make is called without a valid configuration,
it should tell the user what to do.

Revision 0e8c9214ba1d4128cf92442cd343bc3733478261
was a regression which resulted in a message
which was no longer user friendly
(reported by Aurelien Jarno).

This patch restores the old behaviour.

Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 Makefile |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/Makefile b/Makefile
index fa7f851..b1bbe6d 100644
--- a/Makefile
+++ b/Makefile
@@ -75,7 +75,9 @@ SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
 subdir-%: $(GENERATED_HEADERS)
 	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,)
 
+ifneq ($(wildcard config-host.mak),)
 include $(SRC_PATH)/Makefile.objs
+endif
 
 $(common-obj-y): $(GENERATED_HEADERS)
 $(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y)
-- 
1.6.5

Re: [Qemu-devel] Error message regression

[Andreas Färber]

Am 14.01.2010 um 15:50 schrieb Aurelien Jarno:

> Starting with commit 0e8c9214ba1d4128cf92442cd343bc3733478261, when
> trying to run make without running configure first, the error message
> has been changed from:
>
> | $ make
> | Please call configure before running make!
> | make: *** [config-host.mak] Erreur 1
>
> to this more cryptic message:
>
> | $ make
> | Makefile:78: /Makefile.objs: No such file or directory
> | make: *** No rule to make target `/Makefile.objs'.  Stop.

Sorry, didn't test that.

> Any idea how to fix that properly?

I'd assume this is due to $SRC_PATH being undefined. Probably an  
ifneq(...) around the include would do the trick, I'll have a look  
later today.

Andreas

[Qemu-devel] Re: [PATCH] Makefile: Fix message for missing configure

[Andreas Färber]

Am 14.01.2010 um 18:11 schrieb Stefan Weil:

> When make is called without a valid configuration,
> it should tell the user what to do.
>
> Revision 0e8c9214ba1d4128cf92442cd343bc3733478261
> was a regression which resulted in a message
> which was no longer user friendly
> (reported by Aurelien Jarno).
>
> This patch restores the old behaviour.
>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Reviewed-by: Andreas Färber <afaerber@opensolaris.org>

Looks okay, thanks.

Andreas

> ---
> Makefile |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index fa7f851..b1bbe6d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -75,7 +75,9 @@ SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
> subdir-%: $(GENERATED_HEADERS)
> 	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)"  
> TARGET_DIR="$*/" all,)
>
> +ifneq ($(wildcard config-host.mak),)
> include $(SRC_PATH)/Makefile.objs
> +endif
>
> $(common-obj-y): $(GENERATED_HEADERS)
> $(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y)
> -- 
> 1.6.5
>

Re: [Qemu-devel] [PATCH] Makefile: Fix message for missing configure

[Aurelien Jarno]

On Thu, Jan 14, 2010 at 06:11:43PM +0100, Stefan Weil wrote:
> When make is called without a valid configuration,
> it should tell the user what to do.
> 
> Revision 0e8c9214ba1d4128cf92442cd343bc3733478261
> was a regression which resulted in a message
> which was no longer user friendly
> (reported by Aurelien Jarno).
> 
> This patch restores the old behaviour.

Thanks for the quick reaction, applied.

> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  Makefile |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index fa7f851..b1bbe6d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -75,7 +75,9 @@ SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
>  subdir-%: $(GENERATED_HEADERS)
>  	$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,)
>  
> +ifneq ($(wildcard config-host.mak),)
>  include $(SRC_PATH)/Makefile.objs
> +endif
>  
>  $(common-obj-y): $(GENERATED_HEADERS)
>  $(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y)
> -- 
> 1.6.5
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net