All of lore.kernel.org
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix uncompress code compile for different definesof static(void)
Date: Thu, 14 Jan 2010 11:38:15 -0800	[thread overview]
Message-ID: <20100114193815.GA7339@atomide.com> (raw)
In-Reply-To: <20100114091556.GB19197@n2100.arm.linux.org.uk>

* Russell King - ARM Linux <linux@arm.linux.org.uk> [100114 01:14]:
> On Thu, Jan 14, 2010 at 09:29:52AM +0100, Uwe Kleine-K?nig wrote:
> > I think the cleanest solution would be to remove -Dstatic=.  I don't
> > know the exact reason for it being there.
> 
> Thereby breaking the ability to build a relocatable decompressor.
> 
> > Russell, maybe these toolchain problems are gone in the meantime?
> 
> I don't think it was toolchain problems.  Having the text and data
> segments independently relocatable is actually an abuse of the ELF
> format - it's not something it directly supports.
> 
> From what I remember, having 'static' in there results in either
> function calls or static data being indirected through the GOT table,
> which means it has to be relocated along side the data segment - which
> makes the offset between the text and data segments fixed.
> 
> I would not believe that the "problems" have gone because the toolchain
> is working how it's supposed to.
> 
> The -Dstatic= stays.

I've added the compile fix with the subject fixed into Russell's
patch system as 5882/1.

Regards,

Tony

  reply	other threads:[~2010-01-14 19:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-13  2:19 [PATCH] ARM: Fix uncompress code compile for different defines of static(void) Tony Lindgren
2010-01-13  8:49 ` Uwe Kleine-König
2010-01-13 14:26   ` Uwe Kleine-König
2010-01-13 17:14     ` Tony Lindgren
2010-01-13 18:11   ` [PATCH] ARM: Fix uncompress code compile for different definesof static(void) H Hartley Sweeten
2010-01-14  8:29     ` Uwe Kleine-König
2010-01-14  9:15       ` Russell King - ARM Linux
2010-01-14 19:38         ` Tony Lindgren [this message]
2010-01-18 10:44           ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100114193815.GA7339@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.