All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>, Eric Paris <eparis@redhat.com>,
	Wu Fengguang <fengguang.wu@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Cc: Nick Piggin <npiggin@suse.de>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Howells <dhowells@redhat.com>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: <linux-fsdevel@vger.kernel.org>
Subject: [PATCH 1/6] fanotify: fix FMODE_NONOTIFY bit number
Date: Fri, 15 Jan 2010 09:39:55 +0800	[thread overview]
Message-ID: <20100115014422.267373147@intel.com> (raw)
In-Reply-To: 20100115013954.311049665@intel.com

[-- Attachment #1: fanotify-bit-fix --]
[-- Type: text/plain, Size: 1170 bytes --]

FMODE_NONOTIFY=0x800000 collides with __O_SYNC in sparc,
so change it to 0x1000000.

CC: Eric Paris <eparis@redhat.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
 include/asm-generic/fcntl.h |    2 +-
 include/linux/fs.h          |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux.orig/include/asm-generic/fcntl.h	2010-01-05 10:42:36.000000000 +0800
+++ linux/include/asm-generic/fcntl.h	2010-01-05 10:42:57.000000000 +0800
@@ -5,7 +5,7 @@
 
 /*
  * FMODE_EXEC is 0x20
- * FMODE_NONOTIFY is 0x800000
+ * FMODE_NONOTIFY is 0x1000000
  * These cannot be used by userspace O_* until internal and external open
  * flags are split.
  * -Eric Paris
--- linux.orig/include/linux/fs.h	2010-01-05 10:40:33.000000000 +0800
+++ linux/include/linux/fs.h	2010-01-05 10:42:07.000000000 +0800
@@ -88,7 +88,7 @@ struct inodes_stat_t {
 #define FMODE_NOCMTIME		((__force fmode_t)2048)
 
 /* File was opened by fanotify and shouldn't generate fanotify events */
-#define FMODE_NONOTIFY		((__force fmode_t)8388608)
+#define FMODE_NONOTIFY		((__force fmode_t)0x1000000)
 
 /*
  * The below are the various read and write types that we support. Some of



  reply	other threads:[~2010-01-15  1:49 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-15  1:39 [PATCH 0/6] FMODE_NONOTIFY, FMODE_RANDOM and FMODE_NEG_OFFSET bits Wu Fengguang
2010-01-15  1:39 ` Wu Fengguang [this message]
2010-01-15  1:39 ` [PATCH 2/6] bitops: compile time optimization for hweight_long(CONSTANT) Wu Fengguang
2010-01-15  1:39 ` [PATCH 3/6] vfs: O_* bit numbers uniqueness check Wu Fengguang
2010-01-15  1:39 ` [PATCH 4/6] vfs: take f_lock on modifying f_mode after open time Wu Fengguang
2010-01-15  1:39 ` [PATCH 5/6] readahead: introduce FMODE_RANDOM for POSIX_FADV_RANDOM Wu Fengguang
2010-01-15  1:40 ` [PATCH 6/6] vfs: introduce FMODE_NEG_OFFSET for allowing negative f_pos Wu Fengguang
2010-01-16 12:54   ` OGAWA Hirofumi
2010-01-18  0:15     ` KAMEZAWA Hiroyuki
2010-01-18  1:17       ` OGAWA Hirofumi
2010-01-18  1:25         ` KAMEZAWA Hiroyuki
2010-01-18  1:38           ` OGAWA Hirofumi
2010-01-18  2:00             ` KAMEZAWA Hiroyuki
2010-01-18  2:13               ` OGAWA Hirofumi
2010-01-18  2:30                 ` KAMEZAWA Hiroyuki
2010-01-18  3:15                   ` Wu, Fengguang
2010-01-18  3:22                     ` KAMEZAWA Hiroyuki
2010-01-18  5:26                       ` Wu, Fengguang
2010-01-19  0:37                         ` KAMEZAWA Hiroyuki
2010-01-18  1:32         ` OGAWA Hirofumi
2010-01-18  1:49           ` KAMEZAWA Hiroyuki
2010-01-18  1:59             ` OGAWA Hirofumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100115014422.267373147@intel.com \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=eparis@redhat.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.