Re: [PATCH] sanity.bbclass: Reading?/proc/sys/vm/mmap_min_addr is not permitted with 2.6.33+ on host

[Denys Dmytriyenko <denis@denix.org>]

On Fri, Jan 15, 2010 at 06:14:10PM +0100, Marcin Juszkiewicz wrote:
> Dnia niedziela, 3 stycznia 2010 o 01:53:09 Denys Dmytriyenko napisa??(a):
> 
> > BTW, wasn't the latest qemu "fixed" for this mmap() issue?
> 
> It was. I am running qemu 0.12.1 on my Debian host without problem. Did not 
> made recipe for it anyway.
> 
> Attached is cleaned version of Martin's patch which I use with stable/2009 and 
> OE.dev branches. Please Ack it.

Is there any way to remove the check altogether? Are there any other issues, 
besides backward compatibility with older QEMU?

-- 
Denys


> Regards, 
> -- 
> JID:      hrw@jabber.org
> Website:  http://marcin.juszkiewicz.com.pl/
> LinkedIn: http://www.linkedin.com/in/marcinjuszkiewicz

> From 2c335c2bfba52b8a7672cec02159c9d8bba658a1 Mon Sep 17 00:00:00 2001
> From: Martin Jansa <martin.jansa@gmail.com>
> Date: Fri, 15 Jan 2010 18:10:29 +0100
> Subject: [PATCH] sanity.bbclass: handle lack of permission to read /proc/sys/vm/mmap_min_addr
> 
> * With 2.6.33-rc2-00252-ge9e5521 on my host I noticed that
>   "cat /proc/sys/vm/mmap_min_addr" returns now
>   "cat: /proc/sys/vm/mmap_min_addr: Operation not permitted"
>   Its probably becuse of
>   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=0e1a6ef2dea88101b056b6d9984f3325c5efced3
>   But I'm not sure if checking CAP_SYS_RAWIO even for reading this value
>   is intentional or just bug which should be fixed in kernel.
> 
> This patch makes bitbake ignore reading error. Possible QEmu failure is not
> handled yet.
> 
> Signed-off-by: Marcin Juszkiewicz <marcin@juszkiewicz.com.pl>
> ---
>  classes/sanity.bbclass |   13 ++++++++-----
>  1 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/classes/sanity.bbclass b/classes/sanity.bbclass
> index f65df61..f57d8e4 100644
> --- a/classes/sanity.bbclass
> +++ b/classes/sanity.bbclass
> @@ -96,11 +96,14 @@ def check_sanity(e):
>  			if not check_app_exists("qemu-arm", e.data):
>  				messages = messages + "qemu-native was in ASSUME_PROVIDED but the QEMU binaries (qemu-arm) can't be found in PATH"
>  
> -		if os.path.exists("/proc/sys/vm/mmap_min_addr"):
> -			f = file("/proc/sys/vm/mmap_min_addr", "r")
> -			if (f.read().strip() != "0"):
> -				messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 0 in /etc/sysctl.conf.\n"
> -			f.close()
> +		try:
> +			if os.path.exists("/proc/sys/vm/mmap_min_addr"):
> +				f = file("/proc/sys/vm/mmap_min_addr", "r")
> +				if (f.read().strip() != "0"):
> +					messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 0 in /etc/sysctl.conf.\n"
> +				f.close()
> +		except:
> +			pass
>  
>  	for util in required_utilities.split():
>  		if not check_app_exists( util, e.data ):
> -- 
> 1.6.6
> 

> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel