From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Paul E. McKenney" Subject: Re: qemu-kvm.git build problem Date: Sun, 17 Jan 2010 18:09:22 -0800 Message-ID: <20100118020922.GF6241@linux.vnet.ibm.com> References: <4B4AF9D2.3080100@siemens.com> <4B4AFAD9.3010604@redhat.com> <4B4AFBC7.1020801@siemens.com> <4B4BC0F3.2010507@web.de> <20100112005118.GO6632@linux.vnet.ibm.com> <4B4C329F.4010301@web.de> <20100112135018.GE6807@linux.vnet.ibm.com> <4B4E6135.8030206@web.de> <20100114021342.GN6803@linux.vnet.ibm.com> <4B502E40.20409@web.de> Reply-To: paulmck@linux.vnet.ibm.com Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Avi Kivity , Lucas Meneghel Rodrigues , KVM mailing list , Michael Goldish , Eduardo Habkost , Dor Laor To: Jan Kiszka Return-path: Received: from e7.ny.us.ibm.com ([32.97.182.137]:55757 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225Ab0ARGiD (ORCPT ); Mon, 18 Jan 2010 01:38:03 -0500 Received: from d01relay07.pok.ibm.com (d01relay07.pok.ibm.com [9.56.227.147]) by e7.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o0I6Vh6x000473 for ; Mon, 18 Jan 2010 01:31:43 -0500 Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by d01relay07.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o0I6c0rn2072614 for ; Mon, 18 Jan 2010 01:38:00 -0500 Received: from d01av04.pok.ibm.com (loopback [127.0.0.1]) by d01av04.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o0I6c0SB031019 for ; Mon, 18 Jan 2010 01:38:00 -0500 Content-Disposition: inline In-Reply-To: <4B502E40.20409@web.de> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Jan 15, 2010 at 09:58:40AM +0100, Jan Kiszka wrote: > Paul E. McKenney wrote: > > On Thu, Jan 14, 2010 at 01:11:33AM +0100, Jan Kiszka wrote: > >> Paul E. McKenney wrote: > >>> On Tue, Jan 12, 2010 at 09:28:15AM +0100, Jan Kiszka wrote: > >>>> If so, I will try to write something like this the next days. Will > >>>> surely appreciate your review afterwards! > >>> Sounds good! > >>> > >> Here we go, find the commit inlined below. You may be primarily > >> interested in kvm_synchronize_sched_expedited() and the helper thread > >> function kvm_rcu_sync_thread. As I use a dedicated thread I simplified > >> some parts compared to upstream. Light testing indicates that it works. > > > > Cool!!! > > > > Have you had a chance to run rcutorture on this implementation? > > > > No, this would mean backporting rcutorture - is it straightforward > (limited time...)? If you aren't backporting too far, the following commit should do it for you: 804bb8370522a569bd3a732b9de5fbd55e26f155 I do not believe that you should need to run rcutorture on all possible old versions -- instead, pick some recent ones. Please let me know if this does not work out for you. Thanx, Paul