From: Ben Dooks <ben-linux@fluff.org>
To: Kukjin Kim <kgene.kim@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org,
Aditya Pratap Sharma <aditya.ps@samsung.com>,
Atul Dahiya <atul.dahiya@samsung.com>
Subject: Re: [PATCH v2] ARM: SAMSUNG: Move GPIO common functions to plat-samsung for Samsung's SoCs
Date: Mon, 18 Jan 2010 02:21:30 +0000 [thread overview]
Message-ID: <20100118022130.GH10014@trinity.fluff.org> (raw)
In-Reply-To: <1263552730-16187-1-git-send-email-kgene.kim@samsung.com>
On Fri, Jan 15, 2010 at 07:52:10PM +0900, Kukjin Kim wrote:
> This patch moves GPIO common functions (from plat-s3c64xx) into plat-samsung.
> and adds the config option to build the plat-samsung/gpiolib for Samsung SoCs.
>
> Changes since v1:
>
> Address comments from Ben
>
> Signed-off-by: Aditya Pratap Sharma <adityaps@samsung.com>
> Signed-off-by: Atul Dahiya <atul.dahiya@samsung.com>
> Signed-off-by: Kukjin Kim <kgene.kim@samsung.com>
> ---
> arch/arm/plat-s3c/include/plat/gpio-core.h | 3 +
> arch/arm/plat-s3c64xx/Kconfig | 1 +
> arch/arm/plat-s3c64xx/gpiolib.c | 162 +----------------------
> arch/arm/plat-samsung/Kconfig | 7 +
> arch/arm/plat-samsung/Makefile | 1 +
> arch/arm/plat-samsung/gpiolib.c | 202 ++++++++++++++++++++++++++++
> 6 files changed, 216 insertions(+), 160 deletions(-)
> create mode 100644 arch/arm/plat-samsung/gpiolib.c
We add CONFIG_SAMSUNG_GPIOLIB in this patch to indicate our support for
the moved gpiolib code, however this code is only dealing with the case
where we have 4bit control registers, the code to deal with the 2bit
case is still in arch/arm/plat-s3c/gpio.c along with some other common
functionality.
I'm just wondering whether to ask for SAMSUNG_GPIOLIB to be renamed
to SAMSUNG_GPIOLIB_4BIT or leave this for the moment as the older
code is being implicity compiled so could be simply moved from the
arch/arm/plat-s3c to arch/arm/plat-samsung easily.
--
Ben
prev parent reply other threads:[~2010-01-18 2:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 10:52 [PATCH v2] ARM: SAMSUNG: Move GPIO common functions to plat-samsung for Samsung's SoCs Kukjin Kim
2010-01-18 1:52 ` Ben Dooks
2010-01-18 2:21 ` Ben Dooks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118022130.GH10014@trinity.fluff.org \
--to=ben-linux@fluff.org \
--cc=aditya.ps@samsung.com \
--cc=atul.dahiya@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.