From: Stephen Hemminger <shemminger@vyatta.com>
To: Tino Keitel <tino.keitel@tikei.de>
Cc: Mike McCormack <mikem@ring3k.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Regression: Wake on LAN doesn't work in sky2 with 2.6.33-rc4-git2
Date: Mon, 18 Jan 2010 11:52:24 -0800 [thread overview]
Message-ID: <20100118115224.1abde88b@nehalam> (raw)
In-Reply-To: <20100118185245.GA3750@mac.home>
Does it work better if config bit is set here?
---
drivers/net/sky2.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
--- a/drivers/net/sky2.c 2010-01-18 11:45:54.444753324 -0800
+++ b/drivers/net/sky2.c 2010-01-18 11:49:18.475018945 -0800
@@ -283,6 +283,9 @@ static void sky2_power_aux(struct sky2_h
/* turn off "driver loaded LED" */
sky2_write16(hw, B0_CTST, Y2_LED_STAT_OFF);
+
+ /* disable writes to PCI config again */
+ sky2_write8(hw, B2_TST_CTRL1, TST_CFG_WRITE_OFF);
}
static void sky2_gmac_reset(struct sky2_hw *hw, unsigned port)
next prev parent reply other threads:[~2010-01-18 19:52 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 9:10 Regression: Wake on LAN doesn't work in sky2 with 2.6.33-rc4-git2 Tino Keitel
2010-01-15 18:50 ` Stephen Hemminger
2010-01-15 22:23 ` Rafael J. Wysocki
2010-01-17 23:19 ` Tino Keitel
2010-01-18 0:36 ` Rafael J. Wysocki
2010-01-18 8:37 ` Tino Keitel
2010-01-18 11:59 ` Mike McCormack
2010-01-18 18:52 ` Tino Keitel
2010-01-18 19:52 ` Stephen Hemminger [this message]
2010-01-18 20:58 ` Tino Keitel
2010-01-18 21:34 ` Rafael J. Wysocki
2010-01-18 22:43 ` Stephen Hemminger
2010-01-19 10:32 ` Tino Keitel
2010-01-19 18:51 ` Stephen Hemminger
2010-01-19 19:37 ` Tino Keitel
2010-01-24 20:35 ` Rafael J. Wysocki
2010-01-25 4:42 ` Stephen Hemminger
2010-01-25 4:46 ` [PATCH] sky2: revert config space change Stephen Hemminger
2010-01-25 6:36 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118115224.1abde88b@nehalam \
--to=shemminger@vyatta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikem@ring3k.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=tino.keitel@tikei.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.