From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault Date: Mon, 18 Jan 2010 14:03:09 +0200 Message-ID: <20100118120309.GD30698@redhat.com> References: <1263230822-17703-1-git-send-email-ozaki.ryota@gmail.com> <4B54473D.4040700@redhat.com> <20100118114920.GH4704@redhat.com> <4B544C90.5030101@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Daniel P. Berrange" , Ryota Ozaki , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63231 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751331Ab0ARMDL (ORCPT ); Mon, 18 Jan 2010 07:03:11 -0500 Content-Disposition: inline In-Reply-To: <4B544C90.5030101@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jan 18, 2010 at 01:57:04PM +0200, Avi Kivity wrote: > On 01/18/2010 01:49 PM, Daniel P. Berrange wrote: > > > >>Daniel, how is libvirt going to react to this? > >At this precise point in time it won't react since its not using it, but > >in a week's time when we have finished the libvirt code to use 'cpu_set' > >it'll be less happy ! > > > >Can't we actually fix CPU hotplug in the stable tree rather than just > >commenting it out ? > > We should certainly fix it, but I doubt it's a good fit for the stable tree. > > Gleb, what would it take? I have no idea about what causes segfault, so can't really tell how invasive fix would be, but fixing segfault is not enough we will have to backport BIOS code to seabios and IMO this code is too much for stable. -- Gleb.