From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: [PATCH][STABLE-0.12] qemu-kvm: Disable cpu_set command to avoid segfault Date: Mon, 18 Jan 2010 14:17:57 +0200 Message-ID: <20100118121757.GE30698@redhat.com> References: <1263230822-17703-1-git-send-email-ozaki.ryota@gmail.com> <4B54473D.4040700@redhat.com> <20100118114920.GH4704@redhat.com> <4B544C90.5030101@redhat.com> <20100118120309.GD30698@redhat.com> <4B544F48.2020706@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Daniel P. Berrange" , Ryota Ozaki , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mx1.redhat.com ([209.132.183.28]:9700 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754916Ab0ARMR7 (ORCPT ); Mon, 18 Jan 2010 07:17:59 -0500 Content-Disposition: inline In-Reply-To: <4B544F48.2020706@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Mon, Jan 18, 2010 at 02:08:40PM +0200, Avi Kivity wrote: > On 01/18/2010 02:03 PM, Gleb Natapov wrote: > > > >>We should certainly fix it, but I doubt it's a good fit for the stable tree. > >> > >>Gleb, what would it take? > >I have no idea about what causes segfault, so can't really tell how > >invasive fix would be, but fixing segfault is not enough we will have to > >backport BIOS code to seabios and IMO this code is too much for stable. > > I was asking about the BIOS code. Can you point me at it? > This is majority of AML part of it: http://git.kernel.org/?p=virt/kvm/pcbios.git;a=blob;f=acpi-ssdt.dsl;h=d998867d70b6384c1f40356b9dd8a06b78b59022;hb=master Seabios should be changed to allocate MADT table from memory that will be marked as ACPI NVS in e820 and it should pass MADT table address into AML code somehow (BOCH bios put it at address 0x0514 and AML read it from there). Note also that currently seabios created this SSDT dynamically and thus can support any number of vcpus, by porting those changes we will limit it to 15 vpus. -- Gleb.