From: Samuel Ortiz <sameo@linux.intel.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linus Walleij <linus.ml.walleij@gmail.com>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
Christoph Egger <siccegge@stud.informatik.uni-erlangen.de>,
Linus Walleij <linus.walleij@stericsson.com>
Subject: Re: linux-next: trivial tree build failure
Date: Mon, 18 Jan 2010 13:56:30 +0100 [thread overview]
Message-ID: <20100118125630.GE8036@sortiz.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1001181115540.30977@pobox.suse.cz>
Hi Jiri,
On Mon, Jan 18, 2010 at 11:17:19AM +0100, Jiri Kosina wrote:
> On Mon, 18 Jan 2010, Stephen Rothwell wrote:
>
> > Hi Jiri,
> >
> > Today's linux-next build (x86_64_allmodconfig) failed like this:
> >
> > drivers/mfd/ab3100-otp.c: In function 'show_otp':
> > drivers/mfd/ab3100-otp.c:101: error: dereferencing pointer to incomplete type
> > drivers/mfd/ab3100-otp.c:104: error: implicit declaration of function 'seq_printf'
> > drivers/mfd/ab3100-otp.c:102: warning: unused variable 'err'
> > drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_open':
> > drivers/mfd/ab3100-otp.c:116: error: implicit declaration of function 'single_open'
> > drivers/mfd/ab3100-otp.c:116: error: 'ab3100_otp_show' undeclared (first use in this function)
> > drivers/mfd/ab3100-otp.c: At top level:
> > drivers/mfd/ab3100-otp.c:121: error: 'seq_read' undeclared here (not in a function)
> > drivers/mfd/ab3100-otp.c:122: error: 'seq_lseek' undeclared here (not in a function)
> > drivers/mfd/ab3100-otp.c:123: error: 'single_release' undeclared here (not in a function)
> > drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_init_debugfs':
> > drivers/mfd/ab3100-otp.c:134: error: 'err' undeclared (first use in this function)
> > drivers/mfd/ab3100-otp.c: In function 'ab3100_otp_exit_debugfs':
> > drivers/mfd/ab3100-otp.c:140: error: implicit declaration of function 'debugfs_remove_file'
> >
> > Exposed by commit 8dcafdf0475eb4633401d1f0bf0e0d35e4ebb9d5
> > "CONFIG_DEBUG_FS wrongly written as CONFIG_DEBUGFS".
>
> Hmm, mea culpa. I have noticed the build failure myself and notified patch
> author about that, but forgot to drop the patch from my tree afterwards.
> Sorry.
>
> On Mon, 18 Jan 2010, Linus Walleij wrote:
>
> > 2010/1/18 Stephen Rothwell <sfr@canb.auug.org.au>:
> >
> > > Exposed by commit 8dcafdf0475eb4633401d1f0bf0e0d35e4ebb9d5
> > > "CONFIG_DEBUG_FS wrongly written as CONFIG_DEBUGFS".
> > > I have reverted that commit for today.
> >
> > I have sent a proper patch to Sam last night, that fix the #ifdef and
> > makes the code work.
>
> I have dropped the patch from my tree now, and I am not carrying any
> replacement as of now.
I'm carrying Linus patch for it, thanks.
Cheers,
Samuel.
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-01-18 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 5:24 linux-next: trivial tree build failure Stephen Rothwell
2010-01-18 8:36 ` Linus Walleij
2010-01-18 9:01 ` Stephen Rothwell
2010-01-18 10:17 ` Jiri Kosina
2010-01-18 12:56 ` Samuel Ortiz [this message]
2010-01-18 23:40 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118125630.GE8036@sortiz.org \
--to=sameo@linux.intel.com \
--cc=jkosina@suse.cz \
--cc=linus.ml.walleij@gmail.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=siccegge@stud.informatik.uni-erlangen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.