From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NWxq9-000536-Dp for mharc-grub-devel@gnu.org; Mon, 18 Jan 2010 15:04:45 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NWxq7-00052s-JB for grub-devel@gnu.org; Mon, 18 Jan 2010 15:04:43 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NWxq2-00051q-L7 for grub-devel@gnu.org; Mon, 18 Jan 2010 15:04:42 -0500 Received: from [199.232.76.173] (port=37527 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NWxq2-00051m-Gm for grub-devel@gnu.org; Mon, 18 Jan 2010 15:04:38 -0500 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:33032 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NWxq1-0004Y9-UM for grub-devel@gnu.org; Mon, 18 Jan 2010 15:04:38 -0500 Received: from pinux (82-45-164-87.cable.ubr06.hari.blueyonder.co.uk [82.45.164.87]) by mail.pina.cat (Postfix) with ESMTPA id C39352894B248 for ; Mon, 18 Jan 2010 21:04:36 +0100 (CET) Received: by pinux (Postfix, from userid 1000) id 11BD792BAA; Mon, 18 Jan 2010 21:04:35 +0100 (CET) Date: Mon, 18 Jan 2010 20:04:35 +0000 From: Carles Pina i Estany To: The development of GNU GRUB Message-ID: <20100118200435.GA14503@pina.cat> References: <20100118001016.GA12122@pina.cat> <4B54600A.4050904@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4B54600A.4050904@gmail.com> User-Agent: Mutt/1.5.20 (2009-06-14) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: keyboard layout patches X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2010 20:04:44 -0000 Hi, On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > + grub_util_write_image ("GRUBLAY", 7, fp); > + grub_util_write_image ((char *) &version, 4, fp); > > should be macroified and put somewhere in a header instead of duplicating I agree. Any reason that I don't see that in util/grub-mkfont.c: grub_util_write_image ("FILE", 4, file); grub_util_write_image ("PFF2", 4, file); and then in font/font.c: static const char section_names_file[4] = { 'F', 'I', 'L', 'E' }; static const char pff2_magic[4] = { 'P', 'F', 'F', '2' }; ? If should be in a macro (as I think so) I will fix after finishing other things. Cheers, -- Carles Pina i Estany http://pinux.info