From: Simon Wunderlich <simon.wunderlich@s2003.tu-chemnitz.de>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality
Date: Mon, 18 Jan 2010 23:57:01 +0100 [thread overview]
Message-ID: <20100118225701.GA14262@pandem0nium> (raw)
In-Reply-To: <201001181931.22344.lindner_marek@yahoo.de>
[-- Attachment #1: Type: text/plain, Size: 820 bytes --]
Whoops,
this is definitly a bug, thanks for pointing that out. Committed in r1552.
On Mon, Jan 18, 2010 at 07:31:22PM +0800, Marek Lindner wrote:
>
> Hi,
>
> > i've just committed this patch in revision 1551, as no further comments and
> > critiques came in. I would consider this patch rather simple, and as
> > experimental feature it is switched off by default anyways ... :)
> >
> > I've changed only a small thing in the committed patch: When neighbors are
> > purged, the bonding candidate list gets updated instead of bonding
> > switched off.
>
> did not have the time to go through your patch in much detail. I just scrolled
> over it and stumbled over routing.c line 1018. I guess you wanted to write:
> spin_*un*lock_irqsave(&orig_hash_lock, flags);
>
> Regards,
> Marek
>
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2010-01-18 22:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 18:27 [B.A.T.M.A.N.] [PATCH] batman-adv: Add bonding functionality Simon Wunderlich
2010-01-17 20:15 ` Simon Wunderlich
2010-01-18 11:31 ` Marek Lindner
2010-01-18 15:15 ` Andrew Lunn
2010-01-18 15:24 ` Andrew Lunn
2010-01-19 0:12 ` Marek Lindner
2010-01-19 17:44 ` Andrew Lunn
2010-01-18 22:57 ` Simon Wunderlich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118225701.GA14262@pandem0nium \
--to=simon.wunderlich@s2003.tu-chemnitz.de \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.