All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Mark Allyn <mark.a.allyn@intel.com>,
	linux-kernel@vger.kernel.org, alan@linux.intel.com,
	charles.f.johnson@intel.com
Subject: Re: [PATCH] Rename rar_driver to rar_register
Date: Mon, 18 Jan 2010 16:12:05 -0800	[thread overview]
Message-ID: <20100119001205.GC27551@kroah.com> (raw)
In-Reply-To: <1263851158.5591.147.camel@localhost.localdomain>

On Mon, Jan 18, 2010 at 01:45:58PM -0800, Marcel Holtmann wrote:
> Hi Mark,
> 
> > The purpose of this patch is to change the name of rar_register source
> > files (both the .c and .h files) to rar_register.
> > 
> > This is the first of seven patches for the rar_register driver
> > for Sunday, January 17, 2009
> > 
> > This is to clarify that this driver is for the rar_register.
> > 
> > This patch only changes the names. It does not make any changes in
> > any code.
> > 
> > Any checkpatch errors on this code were from the original code. They
> > will be addressed in future patches.
> > 
> > The rar stands for restricted access region. The restricted access
> > region is an area of memory that can be locked from access by the
> > x86 processor.
> > 
> > The purpose of the restricted access region is to safeguard confidential
> > information from any unauthorized software running on the x86 processor.
> > 
> > The purpose of this driver is to enable other drivers to obtain
> > the address ranges of the restricted regions as well as lock them.
> > 
> > This patch is referenced off the linux-next repository as pulled
> > on Sunday, January 17, 2010
> 
> this is a lot of boilerplate that you repeat for every patch in this
> series. It distracts from the actual change you are making. I would
> prefer if you send an introductory/summary email and then focus the
> commit message on the actual change you are making.

As the person who has to edit these commit messages down to nothing, I
totally agree.  Please follow the proper submission guidelines for
patches as described in the Documentation/ directory.

Can you resend all of these please based on that?

thanks,

greg k-h

  reply	other threads:[~2010-01-19  0:15 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 21:21 [PATCH] Rename rar_driver to rar_register Mark Allyn
2010-01-18 21:45 ` Marcel Holtmann
2010-01-19  0:12   ` Greg KH [this message]
2010-01-19  0:12 ` Greg KH
2010-01-19  1:23   ` Alan Cox
2010-01-19  4:06     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100119001205.GC27551@kroah.com \
    --to=greg@kroah.com \
    --cc=alan@linux.intel.com \
    --cc=charles.f.johnson@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=mark.a.allyn@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.