All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Horman <nhorman@tuxdriver.com>
To: linux-sctp@vger.kernel.org
Subject: Question regarding handling of ootb packets
Date: Tue, 19 Jan 2010 02:42:54 +0000	[thread overview]
Message-ID: <20100119024254.GA2161@localhost.localdomain> (raw)

Hey all-
	I'm having a bit of trouble understanding the implementation of
sctp_rcv_ootb.  Specifically I'm wondering why we allow packets checked in
sctp_rcv_ootb with malformed chunks into the receive queue.  For instance, if a
chunk in an ootb packet has a zero length, we break out of the loop and return
0, which lets us eventually call sctp_inq_push to put it on the receive queue,
from which point on we seem to assume the chunk header length field is valid and
correct.  Am I missing something, or is this a bug?

Thanks!
Neil


             reply	other threads:[~2010-01-19  2:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19  2:42 Neil Horman [this message]
2010-01-19  3:23 ` Question regarding handling of ootb packets Wei Yongjun
2010-01-22 12:01 ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100119024254.GA2161@localhost.localdomain \
    --to=nhorman@tuxdriver.com \
    --cc=linux-sctp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.