From: "Shawn O. Pearce" <spearce@spearce.org>
To: git <git@vger.kernel.org>
Subject: why is tagger header optional?
Date: Mon, 18 Jan 2010 22:09:46 -0800 [thread overview]
Message-ID: <20100119060946.GA23212@spearce.org> (raw)
So why is it legal to omit the tagger header from a tag?
E.g. the Linux kernel tag v2.6.12 has no tagger header:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=tag;h=26791a8bcf0e6d33f43aef7682bdb555236d56de
JGit is currently failing on this tag, because its fsck
implementation demands that a tag have a tagger header
that can be parsed as a person identity.
Looking at tag.c's parse_tag_buffer(), the variable sig_line seems
to be expected to point at the "tagger " header (given its name),
but its not actually validated as such.
Is there a version of Git floating around that doesn't create a
tagger header when creating a signed tag? WTF?
--
Shawn.
next reply other threads:[~2010-01-19 6:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 6:09 Shawn O. Pearce [this message]
2010-01-19 6:31 ` why is tagger header optional? Junio C Hamano
2010-01-19 6:32 ` Shawn O. Pearce
2010-01-19 6:35 ` Junio C Hamano
2010-01-19 6:37 ` Shawn O. Pearce
2010-01-19 6:44 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100119060946.GA23212@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.