From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NXDHY-0002xO-Hh
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 07:34:04 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NXDHS-0002vg-SH
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 07:34:03 -0500
Received: from [199.232.76.173] (port=40697 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NXDHS-0002vd-Gr
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 07:33:58 -0500
Received: from mx20.gnu.org ([199.232.41.8]:58095)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <hch@lst.de>) id 1NXDHR-0003cD-Mp
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 07:33:58 -0500
Received: from verein.lst.de ([213.95.11.210])
	by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from <hch@lst.de>)
	id 1NXCNG-0003eA-Nf
	for qemu-devel@nongnu.org; Tue, 19 Jan 2010 06:35:55 -0500
Date: Tue, 19 Jan 2010 12:35:47 +0100
From: Christoph Hellwig <hch@lst.de>
Subject: Re: [Qemu-devel] [PATCH 04/10] qcow2: Return 0/-errno in
	qcow2_alloc_cluster_offset
Message-ID: <20100119113547.GA14641@lst.de>
References: <1263816696-24122-1-git-send-email-kwolf@redhat.com>
	<1263816696-24122-5-git-send-email-kwolf@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1263816696-24122-5-git-send-email-kwolf@redhat.com>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org

> @@ -715,6 +721,7 @@ uint64_t qcow2_alloc_cluster_offset(BlockDriverState *bs,
>  
>          cluster_offset &= ~QCOW_OFLAG_COPIED;
>          m->nb_clusters = 0;
> +        m->depends_on = NULL;

What does this have to do with the rest?

Otherwise looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>