From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 06/15] [swiotlb] In 'swiotlb_init' take
	advantage of the default swiotlb_engine support.
Date: Tue, 19 Jan 2010 12:45:36 -0500
Message-ID: <20100119174536.GO11986@phenom.dumpdata.com>
References: <1263510064-16788-1-git-send-email-konrad.wilk@oracle.com>
	<1263510064-16788-2-git-send-email-konrad.wilk@oracle.com>
	<1263510064-16788-3-git-send-email-konrad.wilk@oracle.com>
	<1263510064-16788-4-git-send-email-konrad.wilk@oracle.com>
	<1263510064-16788-5-git-send-email-konrad.wilk@oracle.com>
	<1263510064-16788-6-git-send-email-konrad.wilk@oracle.com>
	<1263510064-16788-7-git-send-email-konrad.wilk@oracle.com>
	<20100115015741.GF6021@sequoia.sous-sol.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20100115015741.GF6021@sequoia.sous-sol.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Chris Wright <chrisw@sous-sol.org>
Cc: Ian.Campbell@eu.citrix.com, jeremy@goop.org, xen-devel@lists.xensource.com, joerg.roedel@amd.com, fujita.tomonori@lab.ntt.co.jp, iommu@lists.linux-foundation.org, dwmw2@infradead.org, alex.williamson@hp.com
List-Id: xen-devel@lists.xenproject.org

> > +static int swiotlb_release(struct swiotlb_engine *iotlb)
> > +{
> > +	swiotlb_free();
> > +	return 0;
> 
> Do you ever expect a failure case here?  You mentioned wait and flush or
> fail, but that's not done here.

I was thinking to extend that in the next batch of patches. But I can roll
that in here. The check is pretty simple - it checks to see if the index
value has been changed, and if so returns a failure.