From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH 04/15] [swiotlb] Search and replace s/io_tlb/iommu_sw->/ Date: Tue, 19 Jan 2010 12:45:57 -0500 Message-ID: <20100119174557.GP11986@phenom.dumpdata.com> References: <1263510064-16788-1-git-send-email-konrad.wilk@oracle.com> <1263510064-16788-2-git-send-email-konrad.wilk@oracle.com> <1263510064-16788-3-git-send-email-konrad.wilk@oracle.com> <1263510064-16788-4-git-send-email-konrad.wilk@oracle.com> <1263510064-16788-5-git-send-email-konrad.wilk@oracle.com> <20100115014330.GD6021@sequoia.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20100115014330.GD6021@sequoia.sous-sol.org> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Chris Wright Cc: Ian.Campbell@eu.citrix.com, jeremy@goop.org, xen-devel@lists.xensource.com, joerg.roedel@amd.com, fujita.tomonori@lab.ntt.co.jp, iommu@lists.linux-foundation.org, dwmw2@infradead.org, alex.williamson@hp.com List-Id: xen-devel@lists.xenproject.org On Thu, Jan 14, 2010 at 05:43:30PM -0800, Chris Wright wrote: > * Konrad Rzeszutek Wilk (konrad.wilk@oracle.com) wrote: > > We also fix the checkpatch.pl errors that surfaced during > > this conversion. > > > > Signed-off-by: Konrad Rzeszutek Wilk > > --- > > lib/swiotlb.c | 204 +++++++++++++++++++++++++++++---------------------------- > > 1 files changed, 104 insertions(+), 100 deletions(-) > > > > diff --git a/lib/swiotlb.c b/lib/swiotlb.c > > index e84f269..3499001 100644 > > --- a/lib/swiotlb.c > > +++ b/lib/swiotlb.c > > @@ -176,14 +176,14 @@ EXPORT_SYMBOL(swiotlb_register_engine); > > > > void swiotlb_print_info(void) > > { > > - unsigned long bytes = io_tlb_nslabs << IO_TLB_SHIFT; > > + unsigned long bytes = iommu_sw->nslabs << IO_TLB_SHIFT; > > This isn't a bisect friendly way to do this...this would oops w/ > iommu_sw == NULL. Yes. Let me redo this in a friendlier manner.