From mboxrd@z Thu Jan  1 00:00:00 1970
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 01/15] [swiotlb] fix: Update
	'setup_io_tlb_npages' to accept both arguments in either order.
Date: Tue, 19 Jan 2010 14:39:26 -0500
Message-ID: <20100119193925.GA20837@phenom.dumpdata.com>
References: <1263510064-16788-1-git-send-email-konrad.wilk@oracle.com>
	<1263510064-16788-2-git-send-email-konrad.wilk@oracle.com>
	<20100115012213.GA6021@sequoia.sous-sol.org>
	<20100119174729.GR11986@phenom.dumpdata.com>
	<20100119190028.GF3204@sequoia.sous-sol.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20100119190028.GF3204@sequoia.sous-sol.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Chris Wright <chrisw@sous-sol.org>
Cc: Ian.Campbell@eu.citrix.com, jeremy@goop.org, xen-devel@lists.xensource.com, joerg.roedel@amd.com, fujita.tomonori@lab.ntt.co.jp, iommu@lists.linux-foundation.org, dwmw2@infradead.org, alex.williamson@hp.com
List-Id: xen-devel@lists.xenproject.org

> > "swiotlb=force,overflow=32,slabs=1024"
> 
> Right, in which case would the is_digit() check remain ahead of the loop
> to protect the "legacy" format (swiotlb=1024,force), forcing mixing like

So, currently the patch that I posted works fine with the "legacy" format.

> you did to the new format (swiotlb=force,slabs=1024 or
> swiotlb=slabs=1024,force)?

I will make sure that the new patch, which will have follow the format
you mentioned, also work with the "legacy" format.