From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NXNIy-0000Up-6s for mharc-grub-devel@gnu.org; Tue, 19 Jan 2010 18:16:12 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXNIw-0000UL-J6 for grub-devel@gnu.org; Tue, 19 Jan 2010 18:16:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXNIs-0000T4-24 for grub-devel@gnu.org; Tue, 19 Jan 2010 18:16:10 -0500 Received: from [199.232.76.173] (port=45492 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXNIr-0000Sx-TS for grub-devel@gnu.org; Tue, 19 Jan 2010 18:16:05 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:46310 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NXNIr-0002NN-8f for grub-devel@gnu.org; Tue, 19 Jan 2010 18:16:05 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NXNIo-0000Fa-QW for grub-devel@gnu.org; Wed, 20 Jan 2010 00:16:03 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NXNIm-0002YM-HG for grub-devel@gnu.org; Wed, 20 Jan 2010 00:16:00 +0100 Date: Wed, 20 Jan 2010 00:16:00 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100119231600.GK8599@thorin> References: <4B39CC24.9060607@gmail.com> <20100101093222.GU5847@riva.ucam.org> <20100101115256.GG3692@thorin> <4B52FC6F.5060100@gmail.com> <20100119222914.GB8599@thorin> <20100119225648.GH5847@riva.ucam.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20100119225648.GH5847@riva.ucam.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: [PATCH] switch from sprintf to asprintf and snprintf X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2010 23:16:10 -0000 On Tue, Jan 19, 2010 at 10:56:48PM +0000, Colin Watson wrote: > On Tue, Jan 19, 2010 at 11:29:14PM +0100, Robert Millan wrote: > > On Sun, Jan 17, 2010 at 01:02:55PM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > > Robert Millan wrote: > > > > On Fri, Jan 01, 2010 at 09:32:24AM +0000, Colin Watson wrote: > > > >> On Tue, Dec 29, 2009 at 10:30:12AM +0100, Vladimir 'φ-coder/phcoder' Serbinenko wrote: > > > >>> +char *EXPORT_FUNC(grub_asprintf) (const char *fmt, ...) > > > >>> + __attribute__ ((format (printf, 1, 2))); > > > >> > > > >> It's very confusing that you've made grub_asprintf have a dramatically > > > >> different interface from asprintf. Perhaps you could call this > > > >> grub_xasprintf instead? > > > > > > > > Is it feasible to implement the same interface as asprintf instead? > > > > > > it's feasible but the only advantage it gives is the return value nobody > > > uses anyway > > > > What about consistency with what programmers expect? > > > > If you don't want the return value, you can just discard it. > > asprintf is not really an advantageous interface to emulate. It > requires tedious manual error handling and hardly anyone gets it right > (GRUB didn't get it right across the board, before I converted it to > xasprintf!), not to mention that error_code = function (&string, ...) is > unpleasant to start with. xasprintf is a much nicer interface; simply > returning the string is what most programmers *actually* expect unless > they've already bent their brains around asprintf. Meh, I guess I'm one of those programmers who bent their brains. Ok, feel free to go with proposed interface as grub_xasprintf(). -- Robert Millan "Be the change you want to see in the world" -- Gandhi