From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NXNPb-0004ES-O8 for mharc-grub-devel@gnu.org; Tue, 19 Jan 2010 18:23:03 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXNPb-0004EJ-1c for grub-devel@gnu.org; Tue, 19 Jan 2010 18:23:03 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXNPV-0004Dt-KF for grub-devel@gnu.org; Tue, 19 Jan 2010 18:23:01 -0500 Received: from [199.232.76.173] (port=54002 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXNPV-0004Dq-Fl for grub-devel@gnu.org; Tue, 19 Jan 2010 18:22:57 -0500 Received: from xvm-190-8.ghst.net ([217.70.190.8]:38970 helo=aybabtu.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NXNPU-00037w-Vv for grub-devel@gnu.org; Tue, 19 Jan 2010 18:22:57 -0500 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtp (Exim 4.69) (envelope-from ) id 1NXNPS-0000GA-RW for grub-devel@gnu.org; Wed, 20 Jan 2010 00:22:55 +0100 Received: from rmh by thorin with local (Exim 4.69) (envelope-from ) id 1NXNPQ-0002aN-PU for grub-devel@gnu.org; Wed, 20 Jan 2010 00:22:52 +0100 Date: Wed, 20 Jan 2010 00:22:52 +0100 From: Robert Millan To: The development of GNU GRUB Message-ID: <20100119232252.GN8599@thorin> References: <20100118001016.GA12122@pina.cat> <4B54600A.4050904@gmail.com> <20100118200435.GA14503@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100118200435.GA14503@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.18 (2008-05-17) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Subject: Re: keyboard layout patches X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2010 23:23:03 -0000 On Mon, Jan 18, 2010 at 08:04:35PM +0000, Carles Pina i Estany wrote: > On Jan/18/2010, Vladimir '??-coder/phcoder' Serbinenko wrote: > > > + grub_util_write_image ("GRUBLAY", 7, fp); > > + grub_util_write_image ((char *) &version, 4, fp); > > > > should be macroified and put somewhere in a header instead of duplicating > > I agree. Any reason that I don't see that in util/grub-mkfont.c: > > grub_util_write_image ("FILE", 4, file); > grub_util_write_image ("PFF2", 4, file); > > and then in font/font.c: > > static const char section_names_file[4] = { 'F', 'I', 'L', 'E' }; > static const char pff2_magic[4] = { 'P', 'F', 'F', '2' }; > > ? > > If should be in a macro (as I think so) I will fix after finishing other > things. Yeah it should. -- Robert Millan "Be the change you want to see in the world" -- Gandhi