From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pete Zaitcev Subject: Re: [Patch 3/7] tabled: add the status display Date: Wed, 20 Jan 2010 13:19:50 -0700 Message-ID: <20100120131950.2ce72e71@redhat.com> References: <20100114211216.53d51c13@redhat.com> <4B575EDF.3020203@garzik.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <4B575EDF.3020203@garzik.org> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Jeff Garzik Cc: Project Hail List On Wed, 20 Jan 2010 14:51:59 -0500 Jeff Garzik wrote: > On 01/14/2010 11:12 PM, Pete Zaitcev wrote: > > I find it too tiresome to monitor the status with kill -USR1. > > This is more fun. The patch seems not too ugly regarding the factoring > > of the cli_xxx methods. > > > > Signed-Off-By: Pete Zaitcev > > > > --- > > doc/etc.tabled.conf | 3 > > server/Makefile.am | 4 > > server/config.c | 19 +++ > > server/replica.c | 64 +++++++++++- > > server/server.c | 104 +++++++++++++------- > > server/status.c | 218 ++++++++++++++++++++++++++++++++++++++++++ > > server/tabled.h | 12 +- > > 7 files changed, 379 insertions(+), 45 deletions(-) > > applied... but we need some way to either turn this off, or limit to a > list of incoming IP addresses. This is an admin interface, which should > not be automatically available to all end-user applications. I thought it was obvious that StatusPort defaults to off (zero). if (tabled_srv.status_port) net_open_known(tabled_srv.status_port, true); -- Pete