From: "Michael S. Tsirkin" <mst@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: mtosatti@redhat.com, Davide Libenzi <davidel@xmailserver.org>,
kvm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] kvm: fix spurious interrupt with irqfd
Date: Wed, 20 Jan 2010 17:09:50 +0200 [thread overview]
Message-ID: <20100120150950.GD3434@redhat.com> (raw)
In-Reply-To: <4B571CAC.9000902@redhat.com>
On Wed, Jan 20, 2010 at 05:09:32PM +0200, Avi Kivity wrote:
> On 01/20/2010 04:58 PM, Michael S. Tsirkin wrote:
>>
>>> I'm uncomfortable with pushing Davide's patch into stable and possibly
>>> causing regressions with unrelated applications. Can't a guest live
>>> with a spurious interrupt?
>>>
>> Well guests mask/unmask vector on each interrupt, so this will trigger
>> an irq storm I think.
>>
>>
>>> It's not like they're unknown.
>>>
>> Depends on the device really.
>> In theory, if they trigger at an unfortunate time this could cause
>> crashes.
>>
>>
>
> I'd like confirmation on both of these before I push things to stable.
I have observed the interrupt storm. We end up with interrupt being
disabled. Crash is a theoretical issue.
--
MST
next prev parent reply other threads:[~2010-01-20 15:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 17:12 [PATCH 0/2] kvm: fix spurious interrupt with irqfd Michael S. Tsirkin
2010-01-17 12:42 ` Avi Kivity
2010-01-19 14:52 ` Michael S. Tsirkin
2010-01-20 14:10 ` Avi Kivity
2010-01-20 14:58 ` Michael S. Tsirkin
2010-01-20 15:09 ` Avi Kivity
2010-01-20 15:09 ` Michael S. Tsirkin [this message]
2010-01-20 17:19 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100120150950.GD3434@redhat.com \
--to=mst@redhat.com \
--cc=avi@redhat.com \
--cc=davidel@xmailserver.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.