From: Johannes Weiner <hannes@cmpxchg.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
x86@kernel.org
Subject: Re: [RFC 1/1] bootmem: move big allocations behing 4G
Date: Wed, 20 Jan 2010 16:30:00 +0100 [thread overview]
Message-ID: <20100120153000.GA13172@cmpxchg.org> (raw)
In-Reply-To: <4B570A15.8040601@gmail.com>
Hi Jiri,
On Wed, Jan 20, 2010 at 02:50:13PM +0100, Jiri Slaby wrote:
> On 01/19/2010 03:33 PM, Johannes Weiner wrote:
> > --- a/include/linux/bootmem.h
> > +++ b/include/linux/bootmem.h
> > @@ -96,20 +96,26 @@ extern void *__alloc_bootmem_low_node(pg_data_t *pgdat,
> > unsigned long align,
> > unsigned long goal);
> >
> > +#ifdef MAX_DMA32_PFN
> > +#define BOOTMEM_DEFAULT_GOAL (__pa(MAX_DMA32_PFN << PAGE_SHIFT))
> > +#else
> > +#define BOOTMEM_DEFAULT_GOAL MAX_DMA_ADDRESS
>
> I just noticed this should write:
> #define BOOTMEM_DEFAULT_GOAL __pa(MAX_DMA_ADDRESS)
Pardon my sloppiness, it's all backwards. The other case should
be without the __pa(), of course.
I'll send a fixed and tested version later.
Thanks,
Hannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Weiner <hannes@cmpxchg.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
x86@kernel.org
Subject: Re: [RFC 1/1] bootmem: move big allocations behing 4G
Date: Wed, 20 Jan 2010 16:30:00 +0100 [thread overview]
Message-ID: <20100120153000.GA13172@cmpxchg.org> (raw)
In-Reply-To: <4B570A15.8040601@gmail.com>
Hi Jiri,
On Wed, Jan 20, 2010 at 02:50:13PM +0100, Jiri Slaby wrote:
> On 01/19/2010 03:33 PM, Johannes Weiner wrote:
> > --- a/include/linux/bootmem.h
> > +++ b/include/linux/bootmem.h
> > @@ -96,20 +96,26 @@ extern void *__alloc_bootmem_low_node(pg_data_t *pgdat,
> > unsigned long align,
> > unsigned long goal);
> >
> > +#ifdef MAX_DMA32_PFN
> > +#define BOOTMEM_DEFAULT_GOAL (__pa(MAX_DMA32_PFN << PAGE_SHIFT))
> > +#else
> > +#define BOOTMEM_DEFAULT_GOAL MAX_DMA_ADDRESS
>
> I just noticed this should write:
> #define BOOTMEM_DEFAULT_GOAL __pa(MAX_DMA_ADDRESS)
Pardon my sloppiness, it's all backwards. The other case should
be without the __pa(), of course.
I'll send a fixed and tested version later.
Thanks,
Hannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-20 15:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 22:56 [RFC 1/1] bootmem: move big allocations behing 4G Jiri Slaby
2010-01-18 22:56 ` Jiri Slaby
2010-01-19 14:33 ` Johannes Weiner
2010-01-19 14:33 ` Johannes Weiner
2010-01-19 22:02 ` Jiri Slaby
2010-01-19 22:02 ` Jiri Slaby
2010-01-20 13:50 ` Jiri Slaby
2010-01-20 13:50 ` Jiri Slaby
2010-01-20 15:30 ` Johannes Weiner [this message]
2010-01-20 15:30 ` Johannes Weiner
2010-01-20 22:53 ` [PATCH] bootmem: avoid DMA32 zone by default Johannes Weiner
2010-01-20 22:53 ` Johannes Weiner
2010-01-20 23:12 ` Jiri Slaby
2010-01-20 23:12 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100120153000.GA13172@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ralf@linux-mips.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.