From: Frederic Weisbecker <fweisbec@gmail.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 4/6] tracing: Change trace_seq to use separate buffer
Date: Wed, 20 Jan 2010 19:40:50 +0100 [thread overview]
Message-ID: <20100120184046.GA6194@nowhere> (raw)
In-Reply-To: <4B556078.7000004@cn.fujitsu.com>
On Tue, Jan 19, 2010 at 03:34:16PM +0800, Lai Jiangshan wrote:
> @@ -3124,6 +3126,8 @@ waitagain:
> if (cnt >= PAGE_SIZE)
> cnt = PAGE_SIZE - 1;
>
> + trace_seq_reset(&iter->seq);
> +
So we actually add a trace_seq_reset here.
This should have been in the first patch, which drops
the memset, and eventually modified here, just to avoid
breaking things in the middle of a patchset.
Things were already broken though before the memset dropping
patch though in other ways, so it's not that important I guess...
The patch looks good.
next prev parent reply other threads:[~2010-01-20 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 7:34 [PATCH 4/6] tracing: Change trace_seq to use separate buffer Lai Jiangshan
2010-01-20 18:40 ` Frederic Weisbecker [this message]
2010-01-26 3:24 ` Lai Jiangshan
2010-01-30 22:07 ` Frederic Weisbecker
2010-01-20 18:56 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100120184046.GA6194@nowhere \
--to=fweisbec@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.