From: Stephen Hemminger <shemminger@vyatta.com>
To: Alan Cox <alan@linux.intel.com>
Cc: jesse.brandeburg@intel.com, netdev@vger.kernel.org
Subject: Re: [RFC PATCH] e100: Fix workqueue race
Date: Thu, 21 Jan 2010 09:20:35 -0800 [thread overview]
Message-ID: <20100121092035.6c4d398d@nehalam> (raw)
In-Reply-To: <20100121164801.416170b9@linux.intel.com>
On Thu, 21 Jan 2010 16:48:01 +0000
Alan Cox <alan@linux.intel.com> wrote:
> (Incidentally this doesn't seem to be the only net driver that looks
> suspect here)
>
> e100: Fix the TX workqueue race
>
> From: Alan Cox <alan@linux.intel.com>
>
> Nothing stops the workqueue being left to run in parallel with close or a
> few other operations. This causes double unmaps and the like.
>
> See kerneloops.org #1041230 for an example
>
> Signed-off-by: Alan Cox <alan@linux.intel.com>
Most drivers solve this by getting rtnl_lock in the timeout work
function.
--
next prev parent reply other threads:[~2010-01-21 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 16:48 [RFC PATCH] e100: Fix workqueue race Alan Cox
2010-01-21 17:20 ` Stephen Hemminger [this message]
2010-01-22 8:42 ` Jarek Poplawski
2010-01-22 9:07 ` Jarek Poplawski
2010-01-22 9:38 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121092035.6c4d398d@nehalam \
--to=shemminger@vyatta.com \
--cc=alan@linux.intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.