From: Frederic Weisbecker <fweisbec@gmail.com>
To: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
prasad@linux.vnet.ibm.com, maneesh@in.ibm.com
Subject: Re: [patch] HWBKPT FIX: Release the bp slot if arch_validate_hwbkpt_settings() fails.
Date: Thu, 21 Jan 2010 14:12:47 +0100 [thread overview]
Message-ID: <20100121131245.GG5017@nowhere> (raw)
In-Reply-To: <20100121125516.GA32521@in.ibm.com>
On Thu, Jan 21, 2010 at 06:25:16PM +0530, Mahesh Salgaonkar wrote:
>
> On a given architecture, when hardware breakpoint registration fails due
> to un-supported access type (read/write/execute), we loose the bp slot since
> register_perf_hw_breakpoint() does not release the bp slot on failure.
> Hence, any subsequent hardware breakpoint registration starts failing
> with 'no space left on device' error.
>
> This patch introduces error handling in register_perf_hw_breakpoint()
> function and releases bp slot on error.
>
> Signed-off-by: Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>
Thanks. I'm queuing it.
next prev parent reply other threads:[~2010-01-21 13:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20100121125113.152043766@mars.in.ibm.com>
2010-01-21 12:55 ` [patch] HWBKPT FIX: Release the bp slot if arch_validate_hwbkpt_settings() fails Mahesh Salgaonkar
2010-01-21 13:12 ` Frederic Weisbecker [this message]
2010-01-29 9:24 ` [tip:perf/core] hw_breakpoints: " tip-bot for Mahesh Salgaonkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121131245.GG5017@nowhere \
--to=fweisbec@gmail.com \
--cc=ananth@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahesh@linux.vnet.ibm.com \
--cc=maneesh@in.ibm.com \
--cc=mingo@elte.hu \
--cc=prasad@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.