From: Marcelo Tosatti <mtosatti@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Avi Kivity <avi@redhat.com>,
kvm@vger.kernel.org, Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
cotte@de.ibm.com
Subject: Re: [PATCHv2] kvm-s390: fix potential array overrun in intercept handling
Date: Thu, 21 Jan 2010 15:36:56 -0200 [thread overview]
Message-ID: <20100121173656.GF3750@amt.cnet> (raw)
In-Reply-To: <201001211219.07628.borntraeger@de.ibm.com>
On Thu, Jan 21, 2010 at 12:19:07PM +0100, Christian Borntraeger wrote:
> v2: apply Avis suggestions about ARRAY_SIZE.
>
> kvm_handle_sie_intercept uses a jump table to get the intercept handler
> for a SIE intercept. Static code analysis revealed a potential problem:
> the intercept_funcs jump table was defined to contain (0x48 >> 2) entries,
> but we only checked for code > 0x48 which would cause an off-by-one
> array overflow if code == 0x48.
>
> Use the compiler and ARRAY_SIZE to automatically set the limits.
>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
Applied and queued for .33, CC: stable, thanks.
next prev parent reply other threads:[~2010-01-21 18:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 10:56 [PATCH] kvm-s390: fix potential array overrun in intercept handling Christian Borntraeger
2010-01-21 11:00 ` Avi Kivity
2010-01-21 11:19 ` [PATCHv2] " Christian Borntraeger
2010-01-21 11:24 ` Heiko Carstens
2010-01-21 11:32 ` Christian Borntraeger
2010-01-21 17:36 ` Marcelo Tosatti [this message]
2010-01-21 23:15 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121173656.GF3750@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cotte@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.