From: Sheng Yang <sheng@linux.intel.com>
To: kvm@vger.kernel.org
Subject: Re: [PATCH] Debug vcpu add
Date: Thu, 21 Jan 2010 20:31:44 +0800 [thread overview]
Message-ID: <201001212031.45117.sheng@linux.intel.com> (raw)
In-Reply-To: <EB8593BCECAB3D40A8248BE0B6400A3835909017@shzsmsx502.ccr.corp.intel.com>
On Thursday 21 January 2010 19:50:17 Liu, Jinsong wrote:
> From 479e84d9ce9d7d78d845f438071a4b1a44aca0bb Mon Sep 17 00:00:00 2001
> From: Liu, Jinsong <jinsong.liu@intel.com>
> Date: Fri, 22 Jan 2010 03:30:33 +0800
> Subject: [PATCH] Debug vcpu add
Jinsong, this name is pretty strange...
I think something like "Fix vcpu hot add feature" should be more proper...
--
regards
Yang, Sheng
>
> Add 'kvm_vcpu_inited' check so that when adding vcpu it will not
> cause segmentation fault. This is especially necessary when vpu
> hotadd after guestos ready.
>
> Signed-off-by: Liu, Jinsong <jinsong.liu@intel.com>
> ---
> qemu-kvm.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-kvm.c b/qemu-kvm.c
> index 599c3d6..bdf90b4 100644
> --- a/qemu-kvm.c
> +++ b/qemu-kvm.c
> @@ -1618,7 +1618,7 @@ static void kvm_do_load_mpstate(void *_env)
>
> void kvm_load_mpstate(CPUState *env)
> {
> - if (kvm_enabled() && qemu_system_ready)
> + if (kvm_enabled() && qemu_system_ready && kvm_vcpu_inited(env))
> on_vcpu(env, kvm_do_load_mpstate, env);
> }
>
next prev parent reply other threads:[~2010-01-21 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 11:50 [PATCH] Debug vcpu add Liu, Jinsong
2010-01-21 12:31 ` Sheng Yang [this message]
2010-01-23 18:39 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001212031.45117.sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.