From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] smc911x driver: cleanup smc911x_initialize()
Date: Thu, 21 Jan 2010 22:29:24 +0100 [thread overview]
Message-ID: <20100121212924.GC16182@darwin> (raw)
smc911x_initialize(): remove unecessary call to free() and
return 0 in case of failure instead of -1
Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
---
drivers/net/smc911x.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
index 5d51406..f2b5895 100644
--- a/drivers/net/smc911x.c
+++ b/drivers/net/smc911x.c
@@ -242,8 +242,7 @@ int smc911x_initialize(u8 dev_num, int base_addr)
dev = malloc(sizeof(*dev));
if (!dev) {
- free(dev);
- return -1;
+ return 0;
}
memset(dev, 0, sizeof(*dev));
--
1.6.3.1
next reply other threads:[~2010-01-21 21:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 21:29 Matthias Kaehlcke [this message]
2010-01-21 23:01 ` [U-Boot] [PATCH] smc911x driver: cleanup smc911x_initialize() Mike Frysinger
2010-01-22 6:18 ` Matthias Kaehlcke
2010-01-22 7:36 ` Ben Warren
2010-01-22 9:02 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121212924.GC16182@darwin \
--to=matthias@kaehlcke.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.