From: Alex Chiang <achiang@hp.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Ingo Molnar <mingo@elte.hu>,
Linus Torvalds <torvalds@linux-foundation.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
Bjorn Helgaas <bjorn.helgaas@hp.com>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH 9/9] pci: set PCI_PREF_RANGE_TYPE_64 in pci_bridge_check_ranges
Date: Thu, 21 Jan 2010 15:09:10 -0700 [thread overview]
Message-ID: <20100121220910.GL17684@ldl.fc.hp.com> (raw)
In-Reply-To: <4B58CCF4.8070008@kernel.org>
* Yinghai Lu <yinghai@kernel.org>:
> On 01/21/2010 01:32 PM, Alex Chiang wrote:
> >> @@ -359,8 +359,11 @@ static void pci_bridge_check_ranges(struct pci_bus *bus)
> >> }
> >> if (pmem) {
> >> b_res[2].flags |= IORESOURCE_MEM | IORESOURCE_PREFETCH;
> >> - if ((pmem & PCI_PREF_RANGE_TYPE_MASK) == PCI_PREF_RANGE_TYPE_64)
> >> + if ((pmem & PCI_PREF_RANGE_TYPE_MASK) ==
> >> + PCI_PREF_RANGE_TYPE_64) {
> >> b_res[2].flags |= IORESOURCE_MEM_64;
> >> + b_res[2].flags |= PCI_PREF_RANGE_TYPE_64;
> here set PCI_PREF_RANGE_TYPE_64 too.
> >> + }
> >> }
> >
> > My copy of pci_read_bridge_bases() in jbarnes's linux-next tree
> > doesn't do anything like that.
> >
> > 284 void __devinit pci_read_bridge_bases(struct pci_bus *child)
> > 285 {
> > ...
> > 369 if (base <= limit) {
> > 370 res->flags = (mem_base_lo & PCI_PREF_RANGE_TYPE_MASK) |
> > 371 IORESOURCE_MEM | IORESOURCE_PREFETCH;
> so it could save PCI_PREF_RANGE_TYPE_64 here.
> > 372 if (res->flags & PCI_PREF_RANGE_TYPE_64)
> > 373 res->flags |= IORESOURCE_MEM_64;
> > 374 res->start = base;
> > 375 res->end = limit + 0xfffff;
> > 376 dev_printk(KERN_DEBUG, &dev->dev, " bridge window %pR\n", res);
> > 377 }
Hm, ok. Thanks for pointing it out.
/ac
next prev parent reply other threads:[~2010-01-21 22:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 6:14 [PATCH 0/9] pci: update pci bridge resources Yinghai Lu
2010-01-21 6:14 ` [PATCH 1/9] pci: add pci_bridge_release_unused_res and pci_bus_release_unused_bridge_res Yinghai Lu
2010-01-21 18:18 ` Alex Chiang
2010-01-21 19:47 ` Yinghai Lu
2010-01-21 6:14 ` [PATCH 2/9] pci: add failed_list to record failed one for pci_bus_assign_resources Yinghai Lu
2010-01-21 20:41 ` Alex Chiang
2010-01-21 6:14 ` [PATCH 3/9] pci: reject mmio range start from 0 on pci_bridge read Yinghai Lu
2010-01-21 6:14 ` [PATCH 4/9] pci: don't shrink bridge resources Yinghai Lu
2010-01-21 6:14 ` [PATCH 5/9] pci: update bridge res to get more big range in pci assign unssign Yinghai Lu
2010-01-21 6:14 ` [PATCH 6/9] pci: introduce pci_assign_unassigned_bridge_resources Yinghai Lu
2010-01-21 21:02 ` Alex Chiang
2010-01-21 6:14 ` [PATCH 7/9] pci: pciehp clean flow in pciehp_configure_device Yinghai Lu
2010-01-21 21:15 ` Alex Chiang
2010-01-21 6:14 ` [PATCH 8/9] pci: pciehp second try to get big range for pcie devices Yinghai Lu
2010-01-21 21:22 ` Alex Chiang
2010-01-21 6:14 ` [PATCH 9/9] pci: set PCI_PREF_RANGE_TYPE_64 in pci_bridge_check_ranges Yinghai Lu
2010-01-21 21:32 ` Alex Chiang
2010-01-21 21:53 ` Yinghai Lu
2010-01-21 22:09 ` Alex Chiang [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-22 9:02 [PATCH -v19 0/9] pci: update pci bridge resources Yinghai Lu
2010-01-22 9:02 ` [PATCH 9/9] pci: set PCI_PREF_RANGE_TYPE_64 in pci_bridge_check_ranges Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121220910.GL17684@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=bjorn.helgaas@hp.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jbarnes@virtuousgeek.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.