Re: [PATCH 22 of 30] pmd_trans_huge migrate bugcheck

[Andrea Arcangeli <aarcange@redhat.com>]

On Fri, Jan 22, 2010 at 12:01:27AM +0100, Andrea Arcangeli wrote:
> @@ -833,6 +834,9 @@ static int do_move_page_to_node_array(st
>  				!migrate_all)
>  			goto put_and_set;
>  
> +		if (unlikely(PageTransHuge(page)))
> +			if (unlikely(split_huge_page(page)))
> +				goto put_and_set;
>  		err = isolate_lru_page(page);
>  		if (!err) {
>  			list_add_tail(&page->lru, &pagelist);

This was too fast of a patch, I've to move this a few lines above so
the mapcount check will work too (also note, pagetranshuge bugs on
tail pages and I like to keep it that way to be more strict on the
other users, so it should be replaced by pagecompound in addition to
moving it a little up). refcounting will adjust automatically and
atomically during the split, simply mapcount will be >0 after the split
on the tailpage and the tail_page->_count will be boosted by the mapcount too.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>