From: Andi Kleen <andi@firstfloor.org>
To: Valdis.Kletnieks@vt.edu
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
robert.richter@amd.com, oprofile-list@lists.sf.net
Subject: Re: [PATCH] Add Xeon 7500 series support to oprofile
Date: Fri, 22 Jan 2010 09:36:16 +0100 [thread overview]
Message-ID: <20100122083616.GA20592@one.firstfloor.org> (raw)
In-Reply-To: <28939.1264126458@localhost>
>
> I'll bite - why a hex constant rather than the decimal values nearby?
Why not?
>
> Also, should we do something about *cpu_type so it isn't confusing on a 7500
> reporting itself as a i7?
No, that wouldn't be compatible to oprofile userland.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2010-01-22 8:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 22:26 [PATCH] Add Xeon 7500 series support to oprofile Andi Kleen
2010-01-22 2:14 ` Valdis.Kletnieks
2010-01-22 8:36 ` Andi Kleen [this message]
2010-01-22 16:23 ` John Villalovos
2010-01-25 14:32 ` Robert Richter
2010-01-25 14:27 ` Robert Richter
2010-01-25 14:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100122083616.GA20592@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sf.net \
--cc=robert.richter@amd.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.