From: Joerg Roedel <joerg.roedel@amd.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: [PATCH] lib/dma-debug.c: mark file-local struct symbol static.
Date: Fri, 22 Jan 2010 18:01:37 +0100 [thread overview]
Message-ID: <20100122170137.GK8665@amd.com> (raw)
In-Reply-To: <d9a890882c693c1e1d046e034fb8cfb130eafe31.1263858860.git.tfransosi@gmail.com>
On Mon, Jan 18, 2010 at 06:57:33PM -0500, Thiago Farina wrote:
> warning: symbol 'filter_fops' was not declared. Should it be static?
>
> Signed-off-by: Thiago Farina <tfransosi@gmail.com>
> ---
> lib/dma-debug.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/lib/dma-debug.c b/lib/dma-debug.c
> index 7d2f0b3..ba8b670 100644
> --- a/lib/dma-debug.c
> +++ b/lib/dma-debug.c
> @@ -587,7 +587,7 @@ out_unlock:
> return count;
> }
>
> -const struct file_operations filter_fops = {
> +static const struct file_operations filter_fops = {
> .read = filter_read,
> .write = filter_write,
> };
Applied to dma-debug/fixes. Thanks.
Joerg
prev parent reply other threads:[~2010-01-22 17:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 23:57 [PATCH] lib/dma-debug.c: mark file-local struct symbol static Thiago Farina
2010-01-22 17:01 ` Joerg Roedel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100122170137.GK8665@amd.com \
--to=joerg.roedel@amd.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.