From: Johannes Sixt <j6t@kdbg.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: "David Rydh" <dary@math.berkeley.edu>, git@vger.kernel.org
Subject: Re: [PATCH] git-mv: Fix error with multiple sources.
Date: Fri, 22 Jan 2010 19:34:02 +0100 [thread overview]
Message-ID: <201001221934.03346.j6t@kdbg.org> (raw)
In-Reply-To: <7vr5pi8x6z.fsf@alter.siamese.dyndns.org>
On Freitag, 22. Januar 2010, Junio C Hamano wrote:
> Why does '/' matter in builtin-mv.c that needed b8f2626, but we can
> compare with '/' [in make_relative_path()]?
We should be using is_dir_sep() in make_relative_path() as well (see the fixup
that I posted in response to your patch). The thing is that the incorrect
result does not matter from a correctness-POV for the only caller of this
routine.
-- Hannes
next prev parent reply other threads:[~2010-01-22 18:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 20:39 [PATCH] git-mv: Fix error with multiple sources David Rydh
2010-01-22 5:57 ` Junio C Hamano
2010-01-22 16:41 ` David Rydh
2010-01-22 6:17 ` Junio C Hamano
2010-01-22 16:49 ` David Rydh
2010-01-22 6:24 ` Junio C Hamano
[not found] ` <7vr5pi8x6z.fsf@alter.siamese.dyndns.org>
2010-01-22 17:30 ` David Rydh
2010-01-22 18:34 ` Johannes Sixt [this message]
2010-01-22 7:03 ` Matthieu Moy
2010-01-22 7:29 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001221934.03346.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=dary@math.berkeley.edu \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.