From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] ocfs2: add extent block stealing for ocfs2 v4
Date: Fri, 22 Jan 2010 16:15:40 -0800 [thread overview]
Message-ID: <20100123001540.GB8165@mail.oracle.com> (raw)
In-Reply-To: <20100123001322.GA8165@mail.oracle.com>
On Fri, Jan 22, 2010 at 04:13:22PM -0800, Joel Becker wrote:
> > + atomic_set(&osb->s_num_meta_stolen, 0);
> > status = ocfs2_reserve_suballoc_bits(osb, (*ac),
> > EXTENT_ALLOC_SYSTEM_INODE,
> > - slot, NULL, ALLOC_NEW_GROUP);
> > + (u32)osb->slot_num, NULL,
>
> The int-vs-u32 casting is weird. Note sure what to make of it.
> Why does ocfs2_reserve_suballoc_bits() take a u32 instead of an int?
Oh, because the alloc context has a u32. I blame someone. But
let's leave it as you have it for now.
Joel
--
"Depend on the rabbit's foot if you will, but remember, it didn't
help the rabbit."
- R. E. Shay
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
prev parent reply other threads:[~2010-01-23 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 7:59 [Ocfs2-devel] [PATCH 1/1] ocfs2: add extent block stealing for ocfs2 v4 Tiger Yang
2010-01-23 0:13 ` Joel Becker
2010-01-23 0:15 ` Joel Becker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100123001540.GB8165@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.