From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sukadev Bhattiprolu Subject: Re: [PATCH linux-cr] x86-32 and ia32 eclone, checkpoint, restart fixes Date: Fri, 22 Jan 2010 18:38:49 -0800 Message-ID: <20100123023849.GA12398@us.ibm.com> References: <20100123003447.GA5285@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <20100123003447.GA5285-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "Serge E. Hallyn" Cc: Linux Containers List-Id: containers.vger.kernel.org Serge E. Hallyn [serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org] wrote: | Eclone on x86-32 should use esi for 4th arg (upids), not | edi, which is 5th arg. This will require a corresponding fix Good catch and nice debug. | to user-cr, but (a) it's correct and (b) it's required so that | IA32_ARG_FIXUP can put upids in the right register for | process_64.c:sys_eclone(). IA32_ARG_FIXUP will (of course) put | edi into r8, the 5th arg. | | Add the ptregs_syscall stubs for eclone, checkpoint, and restart | for 32-bit api on x86-64. | | With this patch (and proper user-cr), checkpoint and eclone work | on x86-32, x86-64, and in 32-bit mode on x86-64. (restart has not | yet been tested) | | Signed-off-by: Serge E. Hallyn Reviewed-by: Sukadev Bhattiprolu