All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Jason Baron <jbaron@redhat.com>,
	Hitoshi Mitake <mitake@dcl.info.waseda.ac.jp>,
	linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
	Tom Zanussi <tzanussi@gmail.com>,
	Steven Rostedt <srostedt@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Greg Kroah-Hartman <gregkh@suse.de>
Subject: Re: [PATCH 00/12] perf lock: New subcommand "perf lock", for analyzing lock statistics
Date: Sat, 23 Jan 2010 07:57:26 +0100	[thread overview]
Message-ID: <20100123065726.GA15774@elte.hu> (raw)
In-Reply-To: <1264179169.4283.1545.camel@laptop>


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Fri, 2010-01-22 at 17:48 +0100, Peter Zijlstra wrote:
> > On Fri, 2010-01-22 at 11:42 -0500, Jason Baron wrote:
> > > On Fri, Jan 22, 2010 at 10:39:01PM +0900, Hitoshi Mitake wrote:
> > > > Adding new subcommand "perf lock" to perf.
> > > > 
> > > 
> > > looks like a really intresting patch! Does this patch mean that we can
> > > potentially remove CONFIG_LOCK_STAT, now that the functionality is
> > > available via 'perf'? Another desire for me has been to able to run
> > > lockstat on production box. This has not been possible before without
> > > incurring the performance penalty of lockdep. however, with 'perf' tools
> > > ability to be turned on an off, perhaps there is (or we can build) a
> > > mode for lockdep that is lower overhead for this usecase?
> > 
> > boot with: prove_locking=0
> > 
> > This patch still needs all the hooks and bits from lockdep, no way you 
> > want all that in a prodction kernel.
> 
> Also, I suspect lockstat to still be lots faster, since it doesn't need to 
> transfer gobs of data but builds the histogram in-kernel.
> 
> Having the ability to do in-kernel histrograms with perf is something I've 
> thought about but not yet managed to think of a nice way of doing it.

Yeah, that has come up in the past and it would be excellent to have. That 
would allow the removal of the special-purpose lockstat /proc output.

	Ingo

  reply	other threads:[~2010-01-23  6:57 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 13:39 [PATCH 00/12] perf lock: New subcommand "perf lock", for analyzing lock statistics Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 01/12] perf tools: Add __data_loc support Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 02/12] perf: Add util/include/linuxhash.h to include hash.h of kernel Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 03/12] lockdep: Add information of file and line where lock inited to struct lockdep_map Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 04/12] lockdep: Add file and line to initialize sequence of spinlock Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 05/12] lockdep: Add file and line to initialize sequence of rwlock Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 06/12] lockdep: Add file and line to initialize sequence of rwsem Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 07/12] lockdep: Add file and line to initialize sequence of rwsem (x86) Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 08/12] lockdep: Add file and line to initialize sequence of mutex Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 09/12] lockdep: Fix the way to initialize class_mutex for information of file and line Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 10/12] perf lock: Enhance information of lock trace events Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 11/12] perf lock: New subcommand "perf lock", for analyzing lock statistics Hitoshi Mitake
2010-01-28  6:51   ` Hitoshi Mitake
2010-01-28 14:28     ` [PATCH] perf: Add util/include/linux/config.h for including generated autoconf.h of kernel Hitoshi Mitake
2010-01-28 14:44       ` Peter Zijlstra
2010-01-30 11:44         ` Hitoshi Mitake
2010-01-28 22:27       ` Paul Mackerras
2010-01-30 11:51         ` Hitoshi Mitake
2010-01-22 13:39 ` [PATCH 12/12] Revert "perf record: Intercept all events" Hitoshi Mitake
2010-01-25  2:23   ` Arnaldo Carvalho de Melo
2010-01-25 14:47     ` Hitoshi Mitake
2010-01-25 14:50       ` Peter Zijlstra
2010-01-25 14:57       ` Arnaldo Carvalho de Melo
2010-01-26  7:17         ` Hitoshi Mitake
2010-01-22 16:42 ` [PATCH 00/12] perf lock: New subcommand "perf lock", for analyzing lock statistics Jason Baron
2010-01-22 16:48   ` Peter Zijlstra
2010-01-22 16:52     ` Peter Zijlstra
2010-01-23  6:57       ` Ingo Molnar [this message]
2010-01-25 14:15   ` Hitoshi Mitake
2010-01-25 14:48     ` Peter Zijlstra
2010-01-26  7:04       ` Hitoshi Mitake
2010-01-26  4:26     ` Greg KH
2010-01-29 14:34 ` Jens Axboe
2010-01-30 12:00   ` Hitoshi Mitake
2010-01-31 20:44     ` Jens Axboe
2010-01-31 21:07       ` Frederic Weisbecker
2010-01-31 21:11         ` Jens Axboe
2010-02-01  9:15         ` Peter Zijlstra
2010-02-01  9:22           ` Ingo Molnar
2010-02-01 17:58             ` Frederic Weisbecker
2010-02-01 13:23       ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100123065726.GA15774@elte.hu \
    --to=mingo@elte.hu \
    --cc=gregkh@suse.de \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitake@dcl.info.waseda.ac.jp \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.