From: Johannes Sixt <j6t@kdbg.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Thomas Rast <trast@student.ethz.ch>,
git@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Handle double slashes in make_relative_path()
Date: Sat, 23 Jan 2010 20:00:28 +0100 [thread overview]
Message-ID: <201001232000.28896.j6t@kdbg.org> (raw)
In-Reply-To: <201001231448.42721.robin.rosenberg@dewire.com>
On Samstag, 23. Januar 2010, Robin Rosenberg wrote:
> lördagen den 23 januari 2010 14.09.29 skrev Johannes Sixt:
> > The function returns either the input unmodified, or it strips also at
> > least one directory component, except when base is only "/" (or "//" or
> > "///"...). I said in practice, because on Windows it does not make sense
> > to invoke git with (literally)
> >
> > git --git-dir=//server/share/repo.git --work-tree=/ ...
> >
> > i.e., without a drive prefix before the slash of --work-tree.
>
> Why not? //foo/bar/z is just as valid and useful a path as x:/z.
Fortunately, make_relative_path() does not have the slightest problem
with //foo/bar/z, either as value of abs (the path to make relative) or as
base (the path to strip from abs).
-- Hannes
next prev parent reply other threads:[~2010-01-23 19:01 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 0:07 [PATCH] Handle double slashes in make_relative_path() Thomas Rast
2010-01-22 1:40 ` Junio C Hamano
2010-01-22 3:05 ` Junio C Hamano
2010-01-22 8:36 ` Johannes Sixt
2010-01-23 11:40 ` Robin Rosenberg
2010-01-23 13:09 ` Johannes Sixt
2010-01-23 13:48 ` Robin Rosenberg
2010-01-23 19:00 ` Johannes Sixt [this message]
2010-01-23 20:04 ` Junio C Hamano
2010-01-23 20:14 ` Junio C Hamano
2010-01-23 20:41 ` Johannes Sixt
2010-01-23 21:01 ` Sverre Rabbelier
2010-01-24 13:57 ` Thomas Rast
2010-01-24 19:04 ` Bernhard R. Link
2010-01-24 20:05 ` Junio C Hamano
2010-01-24 16:44 ` Johannes Sixt
2010-01-24 18:31 ` Junio C Hamano
2010-01-25 1:06 ` Robin Rosenberg
2010-01-22 21:11 ` Thomas Rast
2010-01-22 23:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001232000.28896.j6t@kdbg.org \
--to=j6t@kdbg.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=robin.rosenberg@dewire.com \
--cc=torvalds@linux-foundation.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.