All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
To: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: And I found the other reason (Re: Found one reason libibnetdisc is slower than subnet_discover)
Date: Sun, 24 Jan 2010 12:56:38 +0200	[thread overview]
Message-ID: <20100124105638.GC13519@me> (raw)
In-Reply-To: <20100122101113.16c6bd20.weiny2-i2BcT+NCU+M@public.gmane.org>

On 10:11 Fri 22 Jan     , Ira Weiny wrote:
> It looks like subnet_discover was actually allowing n+1 smps on the wire.  With this patch:
> 
> diff --git a/tests/subnet_discover.c b/tests/subnet_discover.c
> index acc8c23..22b092a 100644
> --- a/tests/subnet_discover.c
> +++ b/tests/subnet_discover.c
> @@ -189,7 +189,7 @@ static void run_request_queue(int fd, int agent)
>         struct request_queue *q = request_queue.next;
>  
>         while (q) {
> -               if (outstanding > max_outstanding)
> +               if (outstanding >= max_outstanding)
>                         break;
>                 if (send_request(fd, agent, q->trid, q->path, q->path_cnt,
>                                  q->attr_id, q->attr_mod) < 0)

Yes, this is the fix. Thanks. Applied.

Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2010-01-24 10:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22  2:14 Found one reason libibnetdisc is slower than subnet_discover Ira Weiny
     [not found] ` <20100121181418.a9e955bb.weiny2-i2BcT+NCU+M@public.gmane.org>
2010-01-22 18:11   ` And I found the other reason (Re: Found one reason libibnetdisc is slower than subnet_discover) Ira Weiny
     [not found]     ` <20100122101113.16c6bd20.weiny2-i2BcT+NCU+M@public.gmane.org>
2010-01-24 10:56       ` Sasha Khapyorsky [this message]
2010-01-25 15:19   ` Found one reason libibnetdisc is slower than subnet_discover Sasha Khapyorsky
2010-01-25 17:09     ` Ira Weiny
     [not found]       ` <20100125090958.fa63adb6.weiny2-i2BcT+NCU+M@public.gmane.org>
2010-01-25 17:28         ` Sasha Khapyorsky
2010-01-25 17:43           ` Ira Weiny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100124105638.GC13519@me \
    --to=sashak-smomgflxvozwk0htik3j/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=weiny2-i2BcT+NCU+M@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.