All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
To: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: "Richard Röjfors"
	<richard.rojfors-gfIc91nka+FZroRs9YW3xA@public.gmane.org>,
	"Ben Dooks" <ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	"Andrew Morton"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>
Subject: Re: [PATCH RESEND 1/1] i2c: Add support for Xilinx XPS IIC Bus Interface
Date: Sun, 24 Jan 2010 19:54:46 +0100	[thread overview]
Message-ID: <20100124195446.2268fd20@hyperion.delvare> (raw)
In-Reply-To: <20100124181526.GB25641-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

On Sun, 24 Jan 2010 19:15:26 +0100, Wolfram Sang wrote:
> > >> + * i2c-xiic.c
> > > 
> > > the directory path to the file would have been nice.
> > 
> > Will update
> 
> Ben, are you sure? Those filenames (especially with directories) easily go
> stale when reorganizing the tree.

FWIW, I agree with Wolfram on that. Embedding the path in the header
comment of a file doesn't add any value.

-- 
Jean Delvare

  parent reply	other threads:[~2010-01-24 18:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19 16:01 [PATCH RESEND 1/1] i2c: Add support for Xilinx XPS IIC Bus Interface Richard Röjfors
     [not found] ` <4B55D74C.2010806-gfIc91nka+FZroRs9YW3xA@public.gmane.org>
2010-01-24 15:49   ` Ben Dooks
     [not found]     ` <20100124154930.GE28675-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2010-01-24 17:33       ` Richard Röjfors
     [not found]         ` <4B5C8460.2040309-gfIc91nka+FZroRs9YW3xA@public.gmane.org>
2010-01-24 18:15           ` Wolfram Sang
     [not found]             ` <20100124181526.GB25641-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2010-01-24 18:54               ` Jean Delvare [this message]
2010-01-24 19:08               ` Peter Korsgaard
2010-01-26 14:44               ` Ben Dooks
2010-01-26 14:44           ` Ben Dooks
     [not found]             ` <20100126144402.GE12774-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org>
2010-01-26 15:29               ` Richard Röjfors
     [not found]                 ` <4B5F0A42.6060401-gfIc91nka+FZroRs9YW3xA@public.gmane.org>
2010-01-28 15:49                   ` Richard Röjfors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100124195446.2268fd20@hyperion.delvare \
    --to=khali-puyad+kwke1g9huczpvpmw@public.gmane.org \
    --cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
    --cc=ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=richard.rojfors-gfIc91nka+FZroRs9YW3xA@public.gmane.org \
    --cc=w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.