From: tytso@mit.edu
To: Andreas Dilger <adilger@sun.com>
Cc: linux-ext4@vger.kernel.org,
Steven Whitehouse <swhiteho@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: Motion to nuke FS_DIRECTIO_FL
Date: Mon, 25 Jan 2010 03:06:10 -0500 [thread overview]
Message-ID: <20100125080610.GD4372@thunk.org> (raw)
In-Reply-To: <E1520682-CD9F-445E-AF33-D5FCDABA1FF8@sun.com>
On Sun, Jan 24, 2010 at 11:18:47PM -0700, Andreas Dilger wrote:
>
> It doesn't seem that ext2/3/4 are using the 0x00100000 value itself,
> but it seems the VFS is using this value for FS_DIRECTIO_FL. Should
> we reserve this in the ext4 flags also, to avoid collisions? I'm
> not sure what that flag is for, possibly to force all IO to the file
> to be uncached?
Hmm, absolutely nothing seems to use FS_DIRECTIO_FL; it looks like it
was introduced by GFS2 in commit 128e5eba in 2006 and then dropped in
commit c9f6a6bb in 2008, but we never killed the FS_DIRECTIO_FL flag
itself in include/linux/fs.h.
The summary line for c9f6a6bb is a bit amusing:
[GFS2] Remove support for unused and pointless flag
Heh.
Sounds like we should just kill it. Any objections?
- Ted
next prev parent reply other threads:[~2010-01-25 8:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-06 9:25 Please reserve INCOMPAT flags Andreas Dilger
2009-11-30 19:15 ` Andreas Dilger
2009-11-30 19:31 ` Please reserve INCOMPAT_EA_INODE flag Andreas Dilger
2009-11-30 21:16 ` [PATCH] Please reserve INCOMPAT_DIRDATA flag Andreas Dilger
2010-06-02 14:34 ` tytso
2010-06-02 14:34 ` Please reserve INCOMPAT_EA_INODE flag tytso
2009-12-05 4:25 ` Please reserve INCOMPAT flags Aneesh Kumar K.V
2010-01-24 19:48 ` tytso
2010-01-25 6:18 ` Andreas Dilger
2010-01-25 8:06 ` tytso [this message]
2010-01-25 9:31 ` Motion to nuke FS_DIRECTIO_FL Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125080610.GD4372@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=swhiteho@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.