All of lore.kernel.org
 help / color / mirror / Atom feed
From: a.zummo@towertech.it (Alessandro Zummo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] rtc: enable rtc in max8925
Date: Mon, 25 Jan 2010 13:04:55 +0100	[thread overview]
Message-ID: <20100125130455.0efc2dfa@linux.lan.towertech.it> (raw)
In-Reply-To: <771cded01001250355p71099663j385d25fc63a5d63d@mail.gmail.com>

On Mon, 25 Jan 2010 06:55:50 -0500
Haojian Zhuang <haojian.zhuang@gmail.com> wrote:

> On Mon, Jan 25, 2010 at 6:22 AM, Alessandro Zummo <a.zummo@towertech.it> wrote:
> > On Mon, 25 Jan 2010 06:09:04 -0500
> > Haojian Zhuang <haojian.zhuang@gmail.com> wrote:
> >
> >> +
> >> +static struct platform_driver max8925_rtc_driver = {
> >> + ? ? .driver ? ? ? ? = {
> >> + ? ? ? ? ? ? .name ? = "max8925-rtc",
> >> + ? ? ? ? ? ? .owner ?= THIS_MODULE,
> >> + ? ? },
> >> + ? ? .probe ? ? ? ? ?= max8925_rtc_probe,
> >> + ? ? .remove ? ? ? ? = __devexit_p(max8925_rtc_remove),
> >> +};
> >> +
> >> +static int __init max8925_rtc_init(void)
> >> +{
> >> + ? ? return platform_driver_register(&max8925_rtc_driver);
> >> +}
> >> +module_init(max8925_rtc_init);
> >> +
> >> +static void __exit max8925_rtc_exit(void)
> >
> > ?this should be __devexit since you used __devexit_p
> >
> 
> I declared __devexit_p on max8925_rtc_remove. So I need to use
> __devexit on max8925_rtc_remove. I needn't use __devexit on
> max8925_rtc_exit, is it?

 Correct. My fault, sorry.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

  reply	other threads:[~2010-01-25 12:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25 11:09 [PATCH 3/4] rtc: enable rtc in max8925 Haojian Zhuang
2010-01-25 11:22 ` Alessandro Zummo
2010-01-25 11:55   ` Haojian Zhuang
2010-01-25 12:04     ` Alessandro Zummo [this message]
2010-01-29 19:56     ` Samuel Ortiz
2010-02-02 14:23       ` Haojian Zhuang
2010-02-05  9:02         ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100125130455.0efc2dfa@linux.lan.towertech.it \
    --to=a.zummo@towertech.it \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.