From: Izik Eidus <ieidus@redhat.com>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] RFC: alias rework
Date: Mon, 25 Jan 2010 22:40:32 +0200 [thread overview]
Message-ID: <20100125224032.19bc6890@redhat.com> (raw)
In-Reply-To: <20100125202039.GB21800@amt.cnet>
On Mon, 25 Jan 2010 18:20:39 -0200
Marcelo Tosatti <mtosatti@redhat.com> wrote:
> With current code, if a memslot is deleted, access through any aliases
> that use it will fail (BTW it looks this is not properly handled, but
> thats a separate problem).
Yea I had some still open concerns about this code (this why I sent it on RFC)
>
> So AFAICS there is no requirement for an alias to continue "operable"
> if its parent memslot is deleted.
With this patch alias will stop to opearte when the parent is deleted
just like the behivor with the current code...
base_gfn will be set to 0 and npages will be set to 0 as well
(the true values wil be hide in real_base_gfn...), so gfn_to_memslot
and gfn_to_page will fail....
>
> Or is this a feature you need?
I dont need it (I asked Avi to do something), So he said he want to nuke the aliasing
from kvm and keep supporting the old userspace`s
Do you have any other way to achive this?
Btw I do realize it might be better not to push this patch and just keep the old
way of treating aliasing as we have now, I really don`t mind.
>
> Motivation is that nukeing aliases is simpler than adjusting them.
>
Agree.
next prev parent reply other threads:[~2010-01-25 20:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 13:53 [PATCH] RFC: alias rework Izik Eidus
2010-01-25 19:45 ` Marcelo Tosatti
2010-01-25 19:57 ` Izik Eidus
2010-01-25 20:20 ` Marcelo Tosatti
2010-01-25 20:40 ` Izik Eidus [this message]
2010-01-25 20:49 ` Marcelo Tosatti
2010-01-25 21:51 ` Izik Eidus
2010-01-26 14:14 ` Avi Kivity
2010-01-26 14:29 ` Izik Eidus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125224032.19bc6890@redhat.com \
--to=ieidus@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.